Replace Ratio with Fraction

Author: Knio

exifread/classes.py

@@ -1,9 +1,9 @@
 import re
 import struct
+from fractions import Fraction
 from typing import BinaryIO, Dict, Any
 
 from exifread.exif_log import get_logger
-from exifread.utils import Ratio
 from exifread.tags import EXIF_TAGS, DEFAULT_STOP_TAG, FIELD_TYPES, IGNORE_TAGS, makernote
 
 logger = get_logger()
@@ -152,7 +152,7 @@ def _process_field(self, tag_name, count, field_type, type_length, offset):
             for _ in range(count):
                 if field_type in (5, 10):
                     # a ratio
-                    value = Ratio(
+                    value = Fraction(
                         self.s2n(offset, 4, signed),
                         self.s2n(offset + 4, 4, signed)
                     )
@@ -496,14 +496,14 @@ def decode_maker_note(self) -> None:
             self.dump_ifd(0, 'MakerNote', tag_dict=makernote.apple.TAGS)
             self.offset = offset
             return
-        
+
         if make == 'DJI':
             offset = self.offset
             self.offset += note.field_offset
             self.dump_ifd(0, 'MakerNote', tag_dict=makernote.dji.TAGS)
             self.offset = offset
             return
-        
+
         # Canon
         if make == 'Canon':
             self.dump_ifd(note.field_offset, 'MakerNote',

exifread/tags/makernote/nikon.py

@@ -1,5 +1,6 @@
+from fractions import Fraction
 
-from exifread.utils import make_string, Ratio
+from exifread.utils import make_string
 
 
 def ev_bias(seq) -> str:
@@ -46,7 +47,7 @@ def ev_bias(seq) -> str:
     if i == 0:
         ret_str += 'EV'
     else:
-        ratio = Ratio(i, step)
+        ratio = Fraction(i, step)
         ret_str = ret_str + str(ratio) + ' EV'
     return ret_str
 

exifread/utils.py

@@ -79,34 +79,3 @@ def get_gps_coords(tags: dict) -> tuple:
     lat_coord *= (-1) ** (lat_ref_val == 'S')
 
     return (lat_coord, lng_coord)
-
-
-class Ratio(Fraction):
-    """
-    Ratio object that eventually will be able to reduce itself to lowest
-    common denominator for printing.
-    """
-
-    # We're immutable, so use __new__ not __init__
-    def __new__(cls, numerator=0, denominator=None):
-        try:
-            self = super(Ratio, cls).__new__(cls, numerator, denominator)
-        except ZeroDivisionError:
-            self = super(Ratio, cls).__new__(cls)
-            self._numerator = numerator
-            self._denominator = denominator
-        return self
-
-    def __repr__(self) -> str:
-        return str(self)
-
-    @property
-    def num(self):
-        return self.numerator
-
-    @property
-    def den(self):
-        return self.denominator
-
-    def decimal(self) -> float:
-        return float(self)