Show notif on invalid remap rules file

Author: iamkroot

trakt_scrobbler/commands/log.py

@@ -11,17 +11,13 @@ class LogOpenCommand(Command):
 
     def handle(self):
         from trakt_scrobbler.log_config import LOG_PATH
+        from trakt_scrobbler.utils import open_file
 
         if not LOG_PATH.exists():
             self.line(f'Log file not found at "{LOG_PATH}"', "error")
             return 1
         self.info(f'Log file is located at: <comment>"{LOG_PATH}"</comment>')
-        if platform == "darwin":
-            sp.Popen(["open", LOG_PATH])
-        elif platform == "linux":
-            sp.Popen(["xdg-open", LOG_PATH])
-        elif platform == "win32":
-            sp.Popen(["explorer", LOG_PATH])
+        open_file(LOG_PATH)
         self.line(
             "In case this command doesn't work, "
             "manually open the log file from the path."

trakt_scrobbler/mediainfo_remap.py

@@ -293,7 +293,13 @@ def read_file(file: Path) -> List[RemapRule]:
     except FileNotFoundError:
         return []
     except tomllib.TOMLDecodeError:
-        logger.exception(f"Invalid TOML in remap_rules file at {file}. Ignoring.")
+        msg = f"Invalid TOML in remap_rules file at {file}."
+        logger.exception(msg)
+        # lazy import
+        from trakt_scrobbler.notifier import notify, Button
+        from trakt_scrobbler.utils import open_file
+        onclick = Button("Open file", on_pressed=lambda: open_file(file))
+        notify(msg, category="exception", actions=[onclick])
         return []
     return RemapFile.model_validate(data).rules
 

trakt_scrobbler/utils.py

@@ -3,6 +3,7 @@
 import logging.config
 import os
 import re
+import subprocess as sp
 import sys
 import threading
 import time
@@ -197,3 +198,15 @@ def convert(self, value, view) -> re.Pattern:
         except TypeError as e:
             self.fail(u"Couldn't compile regex from '{}'. Error: {}".format(value, e),
                       view, type_error=True)
+
+
+def open_file(path):
+    try:
+        if sys.platform == "darwin":
+            sp.Popen(["open", path])
+        elif sys.platform == "linux":
+            sp.Popen(["xdg-open", path])
+        elif sys.platform == "win32":
+            sp.Popen(["explorer", path])
+    except (sp.CalledProcessError, OSError):
+        logger.warning(f"Failed to open file {path}", exc_info=True)