-
Notifications
You must be signed in to change notification settings - Fork 235
Remove files from library #1344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
ulrikeyang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. This looks good to me.
|
Hi @victorapm . Thanks for setting this up! I need to think about it a bit more before approving. I'm not crazy about moving the multiprecision machinery into the test directory, but maybe that's how it needs to be. I'll look this week when I get back. |
|
Thanks, Rob! I wasn't sure about that either, but couldn't find a better solution for now. Thanks for looking! We can reevaluate this |
|
@victorapm Thanks for this work! Just to add to the discussion, I also would prefer the multiprecision machinery to be outside of the test/ examples directories. I just think it is cleaner and perhaps makes things easier to maintain that way. That said, you have demonstrated how one can use the tools to enable the capabilities in the test directory, though there might be a lighter-weight option to do that. I think in the future, when the multiprecision build becomes the more standard build/ use of hypre, we may revisit this to streamline our regression testing. For now, my work on mixed-precision regression testing is keeping things local to the driver file. If we decide to build the helper functions in multiple precisions, it should be straightforward to adapt to use them. |
|
It looks like the only test driver that needed the different precisions for some of these Generate routines is @oseikuffuor1 : Is the Since it doesn't look like runtime precision is needed, at a minimum I would change the But, if the driver mentioned above is not needed, then we don't need the multi-precision machinery and we can just move the helper functions in the standard way. |
|
The ij_mp driver is needed for testing of single precision preconditioners with double precision solvers. It generates a single precision and a double precision matrix. However, one could just generate double precision matrix and convert it to a single precision matrix. That conversion routine is a true hypre routine which is located outside of the test directory. That would require providing these conversion routines in hypre-3.0, which we hadn't planned yet. Right now we just copy the vector back and forth for the mixed precision preconditioner/solver. |
See #1316 (comment)