Added tests

[ci]

Signed-off-by: Pasindu Tennage <[email protected]>

Author: pasindutennage-da

apps/common/src/main/resources/db/migration/canton-network/postgres/stable/V050__create_scan_config.sql

@@ -2,5 +2,5 @@ CREATE TABLE validator_internal_config
 (
     config_key   text  not null,
     config_value jsonb not null,
-    CONSTRAINT uc_validator_config PRIMARY KEY (config_key)
+    CONSTRAINT uc_validator_internal_config PRIMARY KEY (config_key)
 );

apps/validator/src/main/scala/org/lfdecentralizedtrust/splice/validator/store/ValidatorInternalStore.scala

@@ -5,13 +5,44 @@ package org.lfdecentralizedtrust.splice.validator.store
 
 import com.digitalasset.canton.tracing.TraceContext
 import io.circe.Json
-
-import scala.concurrent.Future
+import io.circe.syntax.*
+import io.circe.{Encoder, Decoder}
+import scala.concurrent.{Future, ExecutionContext}
 
 trait ValidatorInternalStore {
 
   def setConfig(key: String, value: Json)(implicit tc: TraceContext): Future[Unit]
 
   def getConfig(key: String)(implicit tc: TraceContext): Future[Json]
 
+  private val scanInternalConfigKey = "validator_scan_internal_config_key"
+
+  implicit val scanUrlEncoder: Encoder[ScanUrlInternalConfig] =
+    Encoder.forProduct2("svName", "url")(s => (s.svName, s.url))
+  implicit val scanUrlDecoder: Decoder[ScanUrlInternalConfig] =
+    Decoder.forProduct2("svName", "url")(ScanUrlInternalConfig.apply)
+
+  def setScanUrlInternalConfig(
+      value: Seq[ScanUrlInternalConfig]
+  )(implicit tc: TraceContext): Future[Unit] = {
+    setConfig(scanInternalConfigKey, value.asJson)
+  }
+
+  def getScanUrlInternalConfig(
+  )(implicit tc: TraceContext, ec: ExecutionContext): Future[Seq[ScanUrlInternalConfig]] = {
+    getConfig(scanInternalConfigKey).map { json =>
+      if (json.isNull || json.asObject.exists(_.isEmpty)) {
+        Seq.empty[ScanUrlInternalConfig]
+      } else {
+        json.as[Seq[ScanUrlInternalConfig]].toOption.getOrElse {
+          Seq.empty[ScanUrlInternalConfig]
+        }
+      }
+    }
+  }
 }
+
+final case class ScanUrlInternalConfig(
+    svName: String,
+    url: String,
+)

apps/validator/src/main/scala/org/lfdecentralizedtrust/splice/validator/store/db/DbValidatorInternalStore.scala

@@ -34,7 +34,7 @@ class DbValidatorInternalStore(
         ON CONFLICT (config_key) DO UPDATE
         SET config_value = excluded.config_value""".asUpdate
 
-    storage.update(action, "set-validator-config").map(_ => ())
+    storage.update(action, "set-validator-internal-config").map(_ => ())
   }
 
   override def getConfig(key: String)(implicit tc: TraceContext): Future[Json] = {
@@ -43,7 +43,7 @@ class DbValidatorInternalStore(
         WHERE config_key = $key
       """.as[Json].headOption
 
-    val jsonOptionF = storage.querySingle(queryAction, "get-validator-config")
+    val jsonOptionF = storage.querySingle(queryAction, "get-validator-internal-config")
 
     jsonOptionF.value.map {
       _.getOrElse(Json.obj())

apps/validator/src/test/scala/org/lfdecentralizedtrust/splice/store/ValidatorInternalStoreTest.scala

@@ -11,7 +11,10 @@ import com.digitalasset.canton.tracing.TraceContext
 import com.digitalasset.canton.{HasActorSystem, HasExecutionContext}
 import io.circe.Json
 import org.lfdecentralizedtrust.splice.store.db.SplicePostgresTest
-import org.lfdecentralizedtrust.splice.validator.store.ValidatorInternalStore
+import org.lfdecentralizedtrust.splice.validator.store.{
+  ScanUrlInternalConfig,
+  ValidatorInternalStore,
+}
 import org.lfdecentralizedtrust.splice.validator.store.db.DbValidatorInternalStore
 import org.scalatest.matchers.should.Matchers
 import org.scalatest.wordspec.AsyncWordSpec
@@ -29,51 +32,97 @@ abstract class ValidatorInternalStoreTest
     implicit val tc: TraceContext = TraceContext.empty
 
     val configKey = "test-config-key"
-    val initialValues = Json.fromString("payload1")
+    val initialValue = Json.fromString("payload1")
     val otherKey = "other-config"
-    val otherValues = Json.fromString("payload2")
+    val otherValue = Json.fromString("payload2")
 
-    "set and get a configuration successfully" in {
+    "set and get a json payload successfully" in {
       for {
         store <- mkStore()
-        _ <- store.setConfig(configKey, initialValues)
-        retrievedValues <- store.getConfig(configKey)
+        _ <- store.setConfig(configKey, initialValue)
+        retrievedValue <- store.getConfig(configKey)
       } yield {
-        retrievedValues shouldEqual initialValues
+        retrievedValue shouldEqual initialValue
       }
     }
 
     "return an empty JSON for a non-existent key" in {
       for {
         store <- mkStore()
-        retrievedValues <- store.getConfig("non-existent-key")
+        retrievedValue <- store.getConfig("non-existent-key")
       } yield {
-        retrievedValues shouldEqual Json.obj()
+        retrievedValue shouldEqual Json.obj()
       }
     }
 
-    "update an existing configuration on conflict" in {
+    "update an existing payload" in {
       for {
         store <- mkStore()
-        _ <- store.setConfig(configKey, initialValues)
-        _ <- store.setConfig(configKey, otherValues)
-        retrievedValues <- store.getConfig(configKey)
+        _ <- store.setConfig(configKey, initialValue)
+        _ <- store.setConfig(configKey, otherValue)
+        retrievedValue <- store.getConfig(configKey)
       } yield {
-        retrievedValues shouldEqual otherValues
+        retrievedValue shouldEqual otherValue
       }
     }
 
     "handle multiple different keys independently" in {
       for {
         store <- mkStore()
-        _ <- store.setConfig(configKey, initialValues)
-        _ <- store.setConfig(otherKey, otherValues)
+        _ <- store.setConfig(configKey, initialValue)
+        _ <- store.setConfig(otherKey, otherValue)
 
-        mainKeyValues <- store.getConfig(configKey)
-        otherKeyValues <- store.getConfig(otherKey)
+        mainKeyValue <- store.getConfig(configKey)
+        otherKeyValue <- store.getConfig(otherKey)
       } yield {
-        mainKeyValues shouldEqual initialValues
-        otherKeyValues shouldEqual otherValues
+        mainKeyValue shouldEqual initialValue
+        otherKeyValue shouldEqual otherValue
+      }
+    }
+
+    val scanConfig1: Seq[ScanUrlInternalConfig] = Seq(
+      ScanUrlInternalConfig("sv1", "url1"),
+      ScanUrlInternalConfig("sv2", "url2"),
+      ScanUrlInternalConfig("sv3", "url3"),
+      ScanUrlInternalConfig("sv4", "url4"),
+    )
+
+    val scanConfig2: Seq[ScanUrlInternalConfig] = Seq(
+      ScanUrlInternalConfig("sv1", "url5"),
+      ScanUrlInternalConfig("sv2", "url6"),
+      ScanUrlInternalConfig("sv3", "url7"),
+      ScanUrlInternalConfig("sv4", "url8"),
+    )
+
+    "saves a scan config" in {
+      for {
+        store <- mkStore()
+        _ <- store.setScanUrlInternalConfig(scanConfig1)
+        returnConfig <- store.getScanUrlInternalConfig()
+      } yield {
+        returnConfig shouldEqual scanConfig1
+
+      }
+    }
+    "updates a scan config" in {
+      for {
+        store <- mkStore()
+        _ <- store.setScanUrlInternalConfig(scanConfig1)
+        _ <- store.setScanUrlInternalConfig(scanConfig2)
+        returnConfig <- store.getScanUrlInternalConfig()
+      } yield {
+        returnConfig shouldEqual scanConfig2
+
+      }
+    }
+
+    "retrieves an empty scan config" in {
+      for {
+        store <- mkStore()
+        returnConfig <- store.getScanUrlInternalConfig()
+      } yield {
+        returnConfig shouldEqual Seq.empty[ScanUrlInternalConfig]
+
       }
     }