fix ui tests [ci]

Signed-off-by: Paweł Perek <[email protected]>

Author: pawelperek-da

apps/sv/frontend/src/__tests__/governance/proposal-listing.test.tsx

@@ -124,17 +124,17 @@ describe('Inflight Vote Requests', () => {
     const voteTakesEffect = screen.getByTestId(`${uniqueId}-row-vote-takes-effect`);
     expect(voteTakesEffect.textContent).toBe(data.voteTakesEffect);
 
-    const voteStats = screen.getByTestId(`${uniqueId}-row-vote-stats`);
-    expect(voteStats.textContent).toBe('2 Accepted / 3 Rejected');
+    const acceptedVoteStats = screen.getByTestId(`${uniqueId}-row-all-votes-stats-accepted`);
+    expect(acceptedVoteStats.textContent).toBe('2 Accepted');
+
+    const rejectedVoteStats = screen.getByTestId(`${uniqueId}-row-all-votes-stats-rejected`);
+    expect(rejectedVoteStats.textContent).toBe('3 Rejected');
 
     const acceptanceThreshold = screen.getByTestId(`${uniqueId}-row-acceptance-threshold`);
     expect(acceptanceThreshold.textContent).toBe('11');
 
     const yourVote = screen.getByTestId(`${uniqueId}-row-your-vote`);
     expect(yourVote.textContent).toMatch(/No Vote/);
-
-    const viewDetails = screen.getByTestId(`${uniqueId}-row-view-details`);
-    expect(viewDetails).toBeDefined();
   });
 
   test('should render Accepted inflight vote request', () => {
@@ -161,9 +161,9 @@ describe('Inflight Vote Requests', () => {
     );
 
     const yourVote = screen.getByTestId(`${uniqueId}-row-your-vote`);
-    const acceptedIcon = screen.getByTestId(`${uniqueId}-row-your-vote-accepted-icon`);
+    const acceptedIcon = screen.getByTestId(`${uniqueId}-row-your-vote-stats-accepted-icon`);
 
-    expect(acceptedIcon).toBeDefined();
+    expect(acceptedIcon).toBeInTheDocument();
     expect(yourVote.textContent).toMatch(/Accepted/);
   });
 
@@ -191,9 +191,9 @@ describe('Inflight Vote Requests', () => {
     );
 
     const yourVote = screen.getByTestId(`${uniqueId}-row-your-vote`);
-    const rejectedIcon = screen.getByTestId(`${uniqueId}-row-your-vote-rejected-icon`);
+    const rejectedIcon = screen.getByTestId(`${uniqueId}-row-your-vote-stats-rejected-icon`);
 
-    expect(rejectedIcon).toBeDefined();
+    expect(rejectedIcon).toBeInTheDocument();
     expect(yourVote.textContent).toMatch(/Rejected/);
   });
 
@@ -280,17 +280,17 @@ describe('Vote history', () => {
     const status = screen.getByTestId(`${uniqueId}-row-status`);
     expect(status.textContent).toBe(data.status);
 
-    const voteStats = screen.getByTestId(`${uniqueId}-row-vote-stats`);
-    expect(voteStats.textContent).toBe('9 Accepted / 2 Rejected');
+    const acceptedVoteStats = screen.getByTestId(`${uniqueId}-row-all-votes-stats-accepted`);
+    expect(acceptedVoteStats.textContent).toBe('9 Accepted');
+
+    const rejectedVoteStats = screen.getByTestId(`${uniqueId}-row-all-votes-stats-rejected`);
+    expect(rejectedVoteStats.textContent).toBe('2 Rejected');
 
     const acceptanceThreshold = screen.getByTestId(`${uniqueId}-row-acceptance-threshold`);
     expect(acceptanceThreshold.textContent).toBe('11');
 
     const yourVote = screen.getByTestId(`${uniqueId}-row-your-vote`);
     expect(yourVote.textContent).toMatch(/Accepted/);
-
-    const viewDetails = screen.getByTestId(`${uniqueId}-row-view-details`);
-    expect(viewDetails).toBeDefined();
   });
 
   test('should show info message when no vote history is available', async () => {

apps/sv/frontend/src/components/governance/ProposalListingSection.tsx

@@ -181,13 +181,12 @@ const VoteRow: React.FC<VoteRowProps> = props => {
         </TableCell>
       )}
       {showVoteStats && (
-        <TableCell data-testid={`${uniqueId}-row-vote-stats`}>
+        <TableCell data-testid={`${uniqueId}-row-all-votes`}>
           <TableBodyTypography>
-            {/* {voteStats['accepted']} Accepted / {voteStats['rejected']} Rejected */}
             <AllVotes
               acceptedVotes={voteStats['accepted']}
               rejectedVotes={voteStats['rejected']}
-              data-testid={`${uniqueId}-row-all-votes`}
+              data-testid={`${uniqueId}-row-all-votes-stats`}
             />
           </TableBodyTypography>
         </TableCell>
@@ -199,7 +198,7 @@ const VoteRow: React.FC<VoteRowProps> = props => {
       )}
 
       <TableCell data-testid={`${uniqueId}-row-your-vote`}>
-        <VoteStats vote={yourVote} data-testid={`${uniqueId}-row-your-vote`} />
+        <VoteStats vote={yourVote} data-testid={`${uniqueId}-row-your-vote-stats`} />
       </TableCell>
     </TableRow>
   );
@@ -233,7 +232,7 @@ interface VoteStatsProps {
 const VoteStats: React.FC<VoteStatsProps> = ({ vote, count, 'data-testid': testId }) => {
   if (vote === 'accepted') {
     return (
-      <Stack direction="row" gap="4px" alignItems="center">
+      <Stack direction="row" gap="4px" alignItems="center" data-testid={testId}>
         <CheckCircleOutlineIcon
           fontSize="small"
           color="success"
@@ -246,7 +245,7 @@ const VoteStats: React.FC<VoteStatsProps> = ({ vote, count, 'data-testid': testI
 
   if (vote === 'rejected') {
     return (
-      <Stack direction="row" gap="4px" alignItems="center">
+      <Stack direction="row" gap="4px" alignItems="center" data-testid={testId}>
         <CancelOutlinedIcon
           fontSize="small"
           color="error"
@@ -257,7 +256,7 @@ const VoteStats: React.FC<VoteStatsProps> = ({ vote, count, 'data-testid': testI
     );
   }
 
-  return <TableBodyTypography>No Vote</TableBodyTypography>;
+  return <TableBodyTypography data-testid={testId}>No Vote</TableBodyTypography>;
 };
 
 const TableBodyTypography: React.FC<React.PropsWithChildren> = ({ children }) => (