Replace the Custom File Remover with a DirectoryInfo Enumerate

Massively speeds up custom file uninstallation.
A large Randomisation with a lot of custom music and voice packs has gone from taking 10 minutes to uninstall down to just 2, probably the best this code can manage really.

Should also fix a bug where a custom file being present but not in the INI breaks everything, haven't tested that though >_>

Author: Knuxfan24

Sonic-06-Mod-Manager/Sonic-06-Mod-Manager.csproj

@@ -371,7 +371,7 @@
   </ItemGroup>
   <ItemGroup>
     <PackageReference Include="Costura.Fody">
-      <Version>5.2.0</Version>
+      <Version>5.7.0</Version>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
       <PrivateAssets>all</PrivateAssets>
     </PackageReference>

Sonic-06-Mod-Manager/src/UnifyPatcher.cs

@@ -105,7 +105,7 @@ public static void InstallMods(string mod, string name) {
                 //If the file is not an archive or it shouldn't be merged, just copy it
                 } else {
                     // Skip if file doesn't exist in the base game and it's not custom.
-                    if (!File.Exists(vanillaFilePath) && !custom.Contains(Path.GetFileName(file))) return;
+                    if (!File.Exists(vanillaFilePath) && !custom.Contains(Path.GetFileName(file))) continue;
 
                     Console.WriteLine($"[{DateTime.Now:hh:mm:ss tt}] [Copy] {file}");
                     File.Copy(file, vanillaFilePath, true);
@@ -168,19 +168,20 @@ public static void UninstallMods() {
         /// </summary>
         public static void UninstallCustomFilesystem(ListView.ListViewItemCollection listViewItems) {
             if (Paths.CheckFileLegitimacy(Properties.Settings.Default.Path_GameExecutable)) { // If the game directory is empty/doesn't exist, ignore request
+                DirectoryInfo di = new DirectoryInfo(Path.GetDirectoryName(Properties.Settings.Default.Path_GameExecutable));
                 foreach (ListViewItem mod in listViewItems) {
                     string[] custom = INI.DeserialiseKey("Custom", mod.SubItems[6].Text).Split(','); // Deserialise 'Custom' key
 
                     if (custom[0] != string.Empty) { // Speeds things up a bit - ensures it's not checking a default null parameter
                         foreach (string file in custom) {
-                            // Search for all files with filters from custom
-                            List<string> files = Directory.GetFiles(Path.GetDirectoryName(Properties.Settings.Default.Path_GameExecutable), file, SearchOption.AllDirectories).ToList();
-                                
-                            foreach (string customfile in files)
+                            foreach (var fi in di.EnumerateFiles($"*{file}", SearchOption.AllDirectories)) {
                                 try {
-                                    Console.WriteLine($"[{DateTime.Now:hh:mm:ss tt}] [Remove] {customfile}");
-                                    File.Delete(customfile); // If custom archive is found, erase...
-                                } catch { }
+                                    Console.WriteLine($"[{DateTime.Now:hh:mm:ss tt}] [Remove] {fi.Name}");
+                                    File.Delete(fi.FullName); // If custom file is found, erase...
+                                }
+                                catch { }
+
+                            }
                         }
                     }
                 }

Sonic-06-Mod-Manager/src/UnifyProgram.cs

@@ -40,7 +40,7 @@ namespace Unify
 {
     static class Program
     {
-        public static readonly string GlobalVersionNumber = $"Version 3.41";
+        public static readonly string GlobalVersionNumber = $"Version 3.42";
 
 #if !DEBUG
         public static readonly string VersionNumber = GlobalVersionNumber;