You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Fatal error: Uncaught Error: Interface 'Stringable' not found in #1010
After running php-scoper it seems that some interfaces are no scoped.
See the source of file /vendor/symfony/polyfill-php80/PhpToken.php
namespace Symfony\Polyfill\Php80;
class PhpToken implements \Stringable
{
....
}
and file vendor/symfony/polyfill-php80/Resources/stubs/Stringable.php
if (\PHP_VERSION_ID < 80000) {
interface Stringable
{
/**
* @return string
*/
public function __toString();
}
}
are scoped like
namespace ReinosMapsScoped\Symfony\Polyfill\Php80;
class PhpToken implements \Stringable <!-- NOTICE THIS, its not scoped
{
...
}
if (\PHP_VERSION_ID < 80000) {
interface Stringable
{
/**
* @return string
*/
public function __toString();
}
\class_alias('ReinosMapsScoped\\Stringable', 'Stringable', \false);
}
The issue seems that class PhpToken implements \Stringable is not scoped to class PhpToken implements \ ReinosMapsScoped\Stringable
Now it throws an PHP error Fatal error: Uncaught Error: Interface 'Stringable' not found in..... and with adding manually the scoped namespace it fixed the error.
Is this a bug in PHPscoper or a configuration issue? 🤔
You should also have a corresponding class_exists() statement in your scoper-autoload.php so \Stingable should be a registered symbol by the time PhpToken is loaded.
If you still have the problem on master please provide a reproducer so that I can look into it
Indeed, Stringable is there and should be registered. However, the class PhpToken is called first and that class implements the Stringable interface. So at that time when PhpToken is registering, \Stringable is not yet created as alias.
By moving Stringable just before the PhpToken fixed the issue.
@theofidry , do you know of a workaround we could use until this can be fixed? I can confirm that it works if I reorder my exposed classes to this order:
I'm working on a PoC for it. In terms of effort having another setting is not exactly trivial either, so might as well try to fix it the proper way. I don't think it is that hard in the end, but I was on holiday so didn't get that much time to look into it, I hope to fix this within the week or next week though.
Ok I'll need some help here... Could you guys provide a super minimal reproducer?
I identified the source code changes that I need to do, it's not a crazy amount but for the tests it's another story. So I've been trying to implement an e2e test instead to validate my idea first before fixing all the other tests... And I can't make it work.
I did my changes in #1035. There is some source code changes but they actually have no impact yet (I'm tracking the dependencies of the class when aliasing a class, but I do nothing with them for now). The end to end test is in the fixtures/set041-exposed-symbols-hierarchy directory and executed with make e2e_041.
I've tried various things, but I cannot reproduce the issue you describe. I've even added a polyfill-80 structure like to try to reproduce it without having to run an old PHP version but this does not do the trick: for me the StringeableLike interface (which would be the Stringeable of your case) is present in the loader classmap (because it is registered in classmap in the composer.json).
I also notice that PhpToken is namespaced, so I don't get why yours is exposed this way.
Hi @theofidry Its been a while. Sorry for taking sooo long. However, I have no idea how to send you a minimal reproducer. Ideas? I can send you my project that is causing the issue though. Perhaps that is helpful?
Activity
theofidry commentedon Apr 17, 2024
It you're using the latest tagged version it is a known issue, if you're using the master branch however it should be fixed.
You notice you have a class alias statement added:
You should also have a corresponding
class_exists()statement in yourscoper-autoload.phpso\Stingableshould be a registered symbol by the timePhpTokenis loaded.If you still have the problem on master please provide a reproducer so that I can look into it
reinos commentedon May 3, 2024
Hi @theofidry, thanks for your reply!
So I did some digging and I found the issue.
The file
scoper-autoload.phpgenerate this for me.Indeed,
Stringableis there and should be registered. However, the classPhpTokenis called first and that class implements theStringableinterface. So at that time whenPhpTokenis registering,\Stringableis not yet created as alias.By moving
Stringablejust before thePhpTokenfixed the issue.Any idea how we can fix this?
theofidry commentedon May 3, 2024
I see, that's an annoying one... We could fix it for this specific case for now. Fixing this more generally looks a bit tricky, doable but tricky.
incraigulous commentedon May 14, 2024
@theofidry , do you know of a workaround we could use until this can be fixed? I can confirm that it works if I reorder my exposed classes to this order:
humbug_phpscoper_expose_class( 'Stringable', 'CodeZone\Bible\Stringable' );
humbug_phpscoper_expose_class( 'PhpToken', 'CodeZone\Bible\PhpToken' );
incraigulous commentedon May 15, 2024
@theofidry , what about a setting to allow for setting a priority of exposed classes?
Just an idea. I'm sure there is a more elegant solution.
theofidry commentedon May 15, 2024
I'm working on a PoC for it. In terms of effort having another setting is not exactly trivial either, so might as well try to fix it the proper way. I don't think it is that hard in the end, but I was on holiday so didn't get that much time to look into it, I hope to fix this within the week or next week though.
incraigulous commentedon May 15, 2024
🙏 Thank you @theofidry!
theofidry commentedon May 18, 2024
Ok I'll need some help here... Could you guys provide a super minimal reproducer?
I identified the source code changes that I need to do, it's not a crazy amount but for the tests it's another story. So I've been trying to implement an e2e test instead to validate my idea first before fixing all the other tests... And I can't make it work.
I did my changes in #1035. There is some source code changes but they actually have no impact yet (I'm tracking the dependencies of the class when aliasing a class, but I do nothing with them for now). The end to end test is in the
fixtures/set041-exposed-symbols-hierarchydirectory and executed withmake e2e_041.I've tried various things, but I cannot reproduce the issue you describe. I've even added a polyfill-80 structure like to try to reproduce it without having to run an old PHP version but this does not do the trick: for me the
StringeableLikeinterface (which would be theStringeableof your case) is present in the loader classmap (because it is registered inclassmapin thecomposer.json).I also notice that
PhpTokenis namespaced, so I don't get why yours is exposed this way.reinos commentedon Oct 11, 2024
Hi @theofidry Its been a while. Sorry for taking sooo long. However, I have no idea how to send you a minimal reproducer. Ideas? I can send you my project that is causing the issue though. Perhaps that is helpful?
let me know.
theofidry commentedon Oct 12, 2024
No worries, if you can't publish the project maybe you can send a zip with the steps to reproduce it?
reinos commentedon Oct 15, 2024
How can I send you the zip file? Can we get in contact with each other?
theofidry commentedon Oct 15, 2024
You can send them either here at theo.fidry @ gmail.com (and write here when you sent it, as it will likely end up in spam)
reinos commentedon Oct 18, 2024
I send you the project, I hope you can find what the cause of the issue is in this case 🤞🏻
Keep me posted!
theofidry commentedon Oct 21, 2024
Thanks, received
reinos commentedon Oct 21, 2024
Cool, let me know if you have any questions.
reinos commentedon Nov 18, 2024
Hi @theofidry
Any luck on reproducing/fixing this issue?
theofidry commentedon Nov 18, 2024
Sorry couldnt take a look, got a bit busy with my moving. I saved the project you sent me by email, I hope to be able to take a look at it this week
reinos commentedon Apr 11, 2025
Hi @theofidry any news on this one?
reinos commentedon Apr 23, 2025
Is this not the easy fix for now as @incraigulous suggested? It's quite annoying to modify the build over and over.