[CVAT][Exchange Oracle] Use Alembic in tests #2620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
...examples/cvat/exchange-oracle/alembic/versions/1707173682_non_unique_escrows_c1e74c227cfe.py
Outdated
Show resolved
Hide resolved
Bobronium
commented
Nov 1, 2024
...examples/cvat/exchange-oracle/alembic/versions/1707173682_non_unique_escrows_c1e74c227cfe.py
Outdated
Show resolved
Hide resolved
zhiltsov-max
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Previously, to initialise test database, we've dropped all metadata then created it, based on current models. This lacked any awareness of our migrations and schema that was generated by it. Nothing really was testing how schema was applied from migrations, so error in alembic revision file wouldn't affect execution of tests and would be caught only on deployment attempt.
With these changes full
alembic upgrade headandalembic downgrade baseis ran before each test.Since running plain
alembic upgrade/downgradecommands is too slow due to isolated revision executions, before each test session, full SQL ofalembic upgrade headandalembic downgrade head:baseis generated, and then reused for each test case which speeds up things significantly.After tests are executed, the database remains in a clean state with all migrations applied.
Existing migrations had to be modified a bit to ensure they could be rendered as raw SQL in offline mode.
How test the changes
Self-tested in CI.
Related issues