Skip to content

Commit 463f374

Browse files
authored
[Fortune Exchange Oracle] Change reward_amount to string (#2553)
* change reward amount to string * add url to log
1 parent a2e28c9 commit 463f374

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

packages/apps/fortune/exchange-oracle/server/src/modules/job/job.dto.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ export class JobDto {
9999
jobDescription?: string;
100100

101101
@ApiProperty({ name: 'reward_amount' })
102-
rewardAmount?: number;
102+
rewardAmount?: string;
103103

104104
@ApiProperty({ name: 'reward_token' })
105105
rewardToken?: string;

packages/apps/fortune/exchange-oracle/server/src/modules/job/job.service.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -172,8 +172,9 @@ export class JobService {
172172
data.fields?.includes(JobFieldName.RewardAmount) ||
173173
data.sortField === JobSortField.REWARD_AMOUNT
174174
) {
175-
job.rewardAmount =
176-
manifest.fundAmount / manifest.submissionsRequired;
175+
job.rewardAmount = (
176+
manifest.fundAmount / manifest.submissionsRequired
177+
).toString();
177178
}
178179
if (data.fields?.includes(JobFieldName.RewardToken)) {
179180
job.rewardToken = TOKEN;
@@ -189,8 +190,8 @@ export class JobService {
189190

190191
if (data.sortField === JobSortField.REWARD_AMOUNT) {
191192
jobs.sort((a, b) => {
192-
const rewardA = a.rewardAmount ?? 0;
193-
const rewardB = b.rewardAmount ?? 0;
193+
const rewardA = Number(a.rewardAmount ?? 0);
194+
const rewardB = Number(b.rewardAmount ?? 0);
194195
if (data.sort === SortDirection.DESC) {
195196
return rewardB - rewardA;
196197
} else {

packages/apps/human-app/server/src/integrations/exchange-oracle/exchange-oracle.gateway.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ export class ExchangeOracleGateway {
5555
return response.data as T;
5656
} catch (e) {
5757
console.error(
58-
`Error, while executing exchange oracle API call, error details: ${e}`,
58+
`Error, while executing exchange oracle API call to ${options.url}, error details: ${e}`,
5959
);
6060
throw e;
6161
}

0 commit comments

Comments
 (0)