[CVAT][Exchange Oracle] Return correct url from get_reputation_oracle_url (#2562)

* Use correct url for get_reputation_oracle_url

* Add tests for `get_reputation_oracle_url`

* Minor change to re-run the pipeline

Restarting the job doesn't help.

Author: Bobronium

packages/examples/cvat/exchange-oracle/src/chain/kvstore.py

@@ -17,12 +17,12 @@ def get_recording_oracle_url(chain_id: int, escrow_address: str) -> str:
 
 
 def get_reputation_oracle_url(chain_id: int, escrow_address: str) -> str:
-    if url := Config.localhost.recording_oracle_url:
+    if url := Config.localhost.reputation_oracle_url:
         return url
 
     escrow = get_escrow(chain_id, escrow_address)
 
-    return OperatorUtils.get_leader(ChainId(chain_id), escrow.recording_oracle).webhook_url
+    return OperatorUtils.get_leader(ChainId(chain_id), escrow.reputation_oracle).webhook_url
 
 
 def get_job_launcher_url(chain_id: int, escrow_address: str) -> str:

packages/examples/cvat/exchange-oracle/tests/integration/chain/test_kvstore.py

@@ -6,7 +6,12 @@
 from human_protocol_sdk.escrow import EscrowClientError, EscrowData
 from human_protocol_sdk.kvstore import KVStoreClientError, KVStoreUtils
 
-from src.chain.kvstore import get_job_launcher_url, get_recording_oracle_url, register_in_kvstore
+from src.chain.kvstore import (
+    get_job_launcher_url,
+    get_recording_oracle_url,
+    get_reputation_oracle_url,
+    register_in_kvstore,
+)
 from src.core.config import LocalhostConfig
 
 from tests.utils.constants import (
@@ -194,3 +199,25 @@ def set_file_url_and_hash(url: str, key: str):
                     )
                     == PGP_PUBLIC_KEY_URL_2
                 )
+
+    def test_get_reputation_oracle_url_config_url(self):
+        with patch(
+            "src.chain.kvstore.Config.localhost.reputation_oracle_url", DEFAULT_MANIFEST_URL
+        ):
+            reputation_url = get_reputation_oracle_url(self.w3.eth.chain_id, escrow_address)
+            assert reputation_url == DEFAULT_MANIFEST_URL
+
+    def test_get_reputation_oracle_url_from_escrow(self):
+        with (
+            patch("src.chain.kvstore.get_escrow") as mock_escrow,
+            patch("src.chain.kvstore.OperatorUtils.get_leader") as mock_leader,
+            patch("src.chain.kvstore.Config.localhost.reputation_oracle_url", None),
+        ):
+            mock_escrow.return_value = self.escrow_data
+            mock_leader.return_value = MagicMock(webhook_url=DEFAULT_MANIFEST_URL)
+            reputation_url = get_reputation_oracle_url(self.w3.eth.chain_id, escrow_address)
+            assert reputation_url == DEFAULT_MANIFEST_URL
+
+    def test_get_reputation_oracle_url_invalid_escrow(self):
+        with pytest.raises(EscrowClientError, match="Invalid escrow address: invalid address"):
+            get_reputation_oracle_url(self.w3.eth.chain_id, "invalid address")