[CVAT] fix: fixed manifest validation misconfiguration (#3573)

Author: Dzeranov

packages/examples/cvat/exchange-oracle/src/core/manifest.py

@@ -136,6 +136,9 @@ class AnnotationInfo(BaseModel):
     job_size: int = 10
     "Frames per job, validation frames are not included"
 
+    qualifications: list[str] = Field(default_factory=list)
+    "A list of annotator qualifications required for participation"
+
     @model_validator(mode="before")
     @classmethod
     def validate_label_type(cls, values: dict[str, Any]) -> dict[str, Any]:
@@ -177,9 +180,6 @@ class TaskManifest(BaseModel):
     job_bounty: Decimal = Field(ge=0)
     "Assignment bounty, a decimal value in HMT"
 
-    qualifications: list[str] = Field(default_factory=list)
-    "A list of annotator qualifications required for participation"
-
 
 def parse_manifest(manifest: Any) -> TaskManifest:
     return TaskManifest.model_validate(manifest)

packages/examples/cvat/exchange-oracle/src/endpoints/serializers.py

@@ -63,7 +63,7 @@ def serialize_job(
             reward_token=reward_token,
             created_at=project.created_at,
             updated_at=project.updated_at,
-            qualifications=manifest.qualifications,
+            qualifications=manifest.annotation.qualifications,
         )
 
 

packages/examples/cvat/exchange-oracle/src/services/exchange.py

@@ -38,7 +38,7 @@ def create_assignment(
 
         manifest = parse_manifest(get_escrow_manifest(chain_id, escrow_address))
 
-        if not all(q in qualifications for q in manifest.qualifications):
+        if not all(q in qualifications for q in manifest.annotation.qualifications):
             raise UserQualificationError
 
         if cvat_service.has_active_user_assignments(

packages/examples/cvat/exchange-oracle/tests/integration/services/test_exchange.py

@@ -215,7 +215,7 @@ def test_create_assignment_no_required_qualifications(self):
             patch("src.services.exchange.get_escrow_manifest") as mock_get_manifest,
         ):
             manifest = json.load(data)
-            manifest["qualifications"] = ["random_qualification"]
+            manifest["annotation"]["qualifications"] = ["random_qualification"]
             mock_get_manifest.return_value = manifest
             with pytest.raises(Exception, match="User doesn't have required qualifications."):
                 create_assignment(ESCROW_ADDRESS, Networks.localhost, user_address, [])
@@ -244,7 +244,7 @@ def test_create_assignment_with_required_qualifications(self):
             patch("src.services.exchange.cvat_api"),
         ):
             manifest = json.load(data)
-            manifest["qualifications"] = ["test", "test2"]
+            manifest["annotation"]["qualifications"] = ["test", "test2"]
             mock_get_manifest.return_value = manifest
             assignment_id = create_assignment(
                 cvat_project.escrow_address,

packages/examples/cvat/exchange-oracle/tests/utils/manifest.json

@@ -8,13 +8,13 @@
     "user_guide": "https://test.storage.googleapis.com",
     "type": "image_boxes",
     "job_size": 10,
-    "max_time": 300
+    "max_time": 300,
+    "qualifications": []
   },
   "validation": {
     "min_quality": 0.8,
     "val_size": 2,
     "gt_url": "https://test.storage.googleapis.com"
   },
-  "job_bounty": "5.001123929619726",
-  "qualifications": []
+  "job_bounty": "5.001123929619726"
 }