Bart config doesn't need generation parameters #42337
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: bart, mvp |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Member
Author
|
slow bart test won't pass anyway due to weight tying, so skipping it for now |
vasqu
approved these changes
Nov 24, 2025
Contributor
vasqu
left a comment
vasqu
left a comment
There was a problem hiding this comment.
Thx LGTM, just a small nit
And could you also include another fix (I checked locally with #42355 that everything works).
This shouldn't be passed in
from_pretrained anymore and we should rather pass this to generate, i.e. model.generate(..., forced_bos_token_id=0)
| self._commit_hash = kwargs.pop("_commit_hash", None) | ||
| self.transformers_version = kwargs.pop("transformers_version", __version__) | ||
|
|
||
| # Ensure backward compatibility for BART CNN models |
Contributor
There was a problem hiding this comment.
Suggested change
| # Ensure backward compatibility for BART CNN models | |
| # Ensure backward compatibility for models that use `forced_bos_token_id` within their config |
might affect more, nit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As per title, fixes slow tests for BART and MVP