[Attn Masks] Lift bidirectional mask restriction on eager
#42325
+49
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasqu
commented
Nov 21, 2025
Comment on lines
-343
to
-345
| allow_torch_fix (`bool`, optional): | ||
| Whether to update the mask in case a query is not attending to any tokens, to solve a bug in torch's older | ||
| versions. We need an arg to skip it when using eager. By default `True`. |
Contributor
Author
There was a problem hiding this comment.
Doubled comment, unrelated but should be removed nonetheless. Slipped through
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
approved these changes
Nov 21, 2025
Collaborator
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
is there a test we can add for this? Otherwise lgtm!
Contributor
Author
|
Good point, let me check if we properly skip the mask in a test here. |
Contributor
Author
|
run-slow: bart,bert,llama |
Contributor
|
This comment contains models: ["models/bart", "models/bert", "models/llama"] |
Contributor
CI Results✅ No failing test specific to this PR 🎉 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that the torch compiler fuses our eager attention to sdpa automatically under compile, we should take more advantage and allow no masks on bidirectional masks without padding == fa backend. This restriction is also unnecessary and I'm not sure why I had this one to begin with.
Fuse strategies can be seen here: