Skip to content

Commit ff96397

Browse files
committed
[#327]fix swagger test case randomly fail
1 parent 953b219 commit ff96397

File tree

4 files changed

+42
-13
lines changed

4 files changed

+42
-13
lines changed

integration-tests/discovery-tests/price-provider/pom.xml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,10 @@
4040
<groupId>com.huaweicloud</groupId>
4141
<artifactId>spring-cloud-starter-huawei-service-engine</artifactId>
4242
</dependency>
43+
<dependency>
44+
<groupId>io.swagger</groupId>
45+
<artifactId>swagger-core</artifactId>
46+
</dependency>
4347
</dependencies>
4448

4549
<build>

integration-tests/discovery-tests/price-provider/src/main/java/com/huaweicloud/sample/SchemaController.java

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,9 @@
3232

3333
import com.huaweicloud.common.schema.ServiceCombSwaggerHandler;
3434

35+
import io.swagger.models.Swagger;
36+
import io.swagger.util.Yaml;
37+
3538
/**
3639
* Class for testing schema generator
3740
*/
@@ -41,17 +44,17 @@ public class SchemaController {
4144
ServiceCombSwaggerHandler serviceCombSwaggerHandler;
4245

4346
@RequestMapping("/testSchemaGenerator")
44-
public String testSchemaGenerator() {
47+
public String testSchemaGenerator() throws Exception {
4548
List<String> schemas = serviceCombSwaggerHandler.getSchemaIds();
4649
assertThat(schemas.size()).isGreaterThan(2);
4750
Map<String, String> schemaContents = serviceCombSwaggerHandler.getSchemasMap();
4851
assertThat(schemaContents.size()).isGreaterThan(2);
4952

50-
String a1 = schemaContents.get("SchemaContentController").replaceAll("\\s", "");
51-
String fileContent = readFile("SchemaContentController.yaml");
52-
fileContent = fileContent.substring(fileContent.indexOf("---") + 3);
53-
String a2 = fileContent.replaceAll("\\s", "");
54-
if (a1.equals(a2)) {
53+
String a1 = schemaContents.get("SchemaContentController");
54+
String a2 = readFile("SchemaContentController.yaml");
55+
Swagger swagger2 = Yaml.mapper().readValue(a2, Swagger.class);
56+
Swagger swagger1 = Yaml.mapper().readValue(a1, Swagger.class);
57+
if (swagger1.equals(swagger2)) {
5558
return "success";
5659
} else {
5760
return a1;

spring-cloud-huawei-dependencies/pom.xml

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,9 @@
4242
<snakeyaml.version>1.26</snakeyaml.version>
4343
<commons-configuration.version>1.10</commons-configuration.version>
4444
<websocket.version>1.5.0</websocket.version>
45+
<spring-fox.version>3.0.0</spring-fox.version>
46+
<swagger-core.version>2.1.9</swagger-core.version>
47+
<swagger-core-v2.version>1.6.2</swagger-core-v2.version>
4548
</properties>
4649

4750
<dependencyManagement>
@@ -71,6 +74,32 @@
7174
<scope>import</scope>
7275
</dependency>
7376

77+
<!-- swagger -->
78+
<dependency>
79+
<groupId>io.springfox</groupId>
80+
<artifactId>springfox-boot-starter</artifactId>
81+
<version>${spring-fox.version}</version>
82+
</dependency>
83+
<dependency>
84+
<groupId>io.swagger.core.v3</groupId>
85+
<artifactId>swagger-core</artifactId>
86+
<version>${swagger-core.version}</version>
87+
</dependency>
88+
<dependency>
89+
<groupId>io.swagger</groupId>
90+
<artifactId>swagger-core</artifactId>
91+
<version>${swagger-core-v2.version}</version>
92+
</dependency>
93+
<dependency>
94+
<groupId>io.swagger</groupId>
95+
<artifactId>swagger-models</artifactId>
96+
<version>${swagger-core-v2.version}</version>
97+
</dependency>
98+
<dependency>
99+
<groupId>io.swagger</groupId>
100+
<artifactId>swagger-annotations</artifactId>
101+
<version>${swagger-core-v2.version}</version>
102+
</dependency>
74103
<!-- servicecomb -->
75104
<dependency>
76105
<groupId>org.apache.servicecomb</groupId>

spring-cloud-huawei-swagger/pom.xml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -28,21 +28,14 @@
2828

2929
<artifactId>spring-cloud-huawei-swagger</artifactId>
3030

31-
<properties>
32-
<spring-fox.version>3.0.0</spring-fox.version>
33-
<swagger-core.version>2.1.9</swagger-core.version>
34-
</properties>
35-
3631
<dependencies>
3732
<dependency>
3833
<groupId>io.springfox</groupId>
3934
<artifactId>springfox-boot-starter</artifactId>
40-
<version>${spring-fox.version}</version>
4135
</dependency>
4236
<dependency>
4337
<groupId>io.swagger.core.v3</groupId>
4438
<artifactId>swagger-core</artifactId>
45-
<version>${swagger-core.version}</version>
4639
</dependency>
4740
<dependency>
4841
<groupId>com.huaweicloud</groupId>

0 commit comments

Comments
 (0)