Skip to content

Discussion: sdk_max_attempts naming #113

@leggetter

Description

@leggetter

@alexluong I'm wondering if we should rename sdk_max_attempts to max_retry_attempts?

  1. Why do we need to leak that this is a config option passed to the SDK?
  2. We're missing that this is config about how many "retries" to attempt. So, how about adding retry to the name?

The release has gone out as a beta, so if we agree on this change, I'd suggest we rename it as a breaking change in the v0.5.0 full release.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions