feat: Create dedicated network component for confluent kafka [DEVOP-2387] #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bibek4699
changed the title
jai
reviewed
Feb 11, 2023
| @@ -0,0 +1,44 @@ | |||
| <!-- BEGIN_TF_DOCS --> | |||
Contributor
There was a problem hiding this comment.
title/please describe the module
jai
suggested changes
Feb 11, 2023
| } | ||
|
|
||
| output "confluent_resource_name" { | ||
| description = "The Confluent Resource Name of the Network." |
Contributor
There was a problem hiding this comment.
please standardize whether descriptions have/don't have punctuations
jai
suggested changes
Feb 11, 2023
| @@ -0,0 +1,28 @@ | |||
| resource "random_id" "suffix" { | |||
Contributor
There was a problem hiding this comment.
please add a README to this folder
MXfive
suggested changes
Feb 14, 2023
MXfive
left a comment
MXfive
left a comment
There was a problem hiding this comment.
Just saw my comments from the other week were still pending.
| @@ -0,0 +1,10 @@ | |||
| terraform { | |||
| required_version = ">= 0.13" | |||
There was a problem hiding this comment.
Suggested change
| required_version = ">= 0.13" | |
| required_version = ">= 1.3" |
| @@ -0,0 +1,3 @@ | |||
| module examples/confluent-dedicated-cluster | |||
There was a problem hiding this comment.
Why do we have this in the examples folder?
Comment on lines
+30
to
+31
| default = "PEERING" | ||
| validation { |
There was a problem hiding this comment.
Suggested change
| default = "PEERING" | |
| validation { | |
| default = "PEERING" | |
| validation { |
Comment on lines
+39
to
+40
| type = string | ||
| validation { |
There was a problem hiding this comment.
Suggested change
| type = string | |
| validation { | |
| type = string | |
| validation { |
Comment on lines
+31
to
+41
| display_name = var.confluent_network_peering_name | ||
| gcp { | ||
| project = var.gcp_project_id | ||
| vpc_network = var.gcp_vpc_network | ||
| #customer_region = var.region | ||
| import_custom_routes = var.import_custom_routes | ||
| } | ||
| environment { | ||
| id = var.environment_id | ||
| } | ||
| network { |
There was a problem hiding this comment.
Suggested change
| display_name = var.confluent_network_peering_name | |
| gcp { | |
| project = var.gcp_project_id | |
| vpc_network = var.gcp_vpc_network | |
| #customer_region = var.region | |
| import_custom_routes = var.import_custom_routes | |
| } | |
| environment { | |
| id = var.environment_id | |
| } | |
| network { | |
| display_name = var.confluent_network_peering_name | |
| gcp { | |
| project = var.gcp_project_id | |
| vpc_network = var.gcp_vpc_network | |
| #customer_region = var.region | |
| import_custom_routes = var.import_custom_routes | |
| } | |
| environment { | |
| id = var.environment_id | |
| } | |
| network { |
Why the commented out customer_region ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please confirm that you have done the following before requesting reviews:
Description
Provision network and peering component for confluent Kafka
Terratest file to test the component
This change is