upgrade terraform 0.8.8 #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we aren't doing this anymore. all values are being set by API
Remove xml gen
go has somewhat permissive and obnoxious rules for occluding outter scope variables. bit me on the error handling
stop occluding the error message
move the java specific things into a java7 checked block started to add a python test config but need to sort out what exactly the apps we're testing are. I can't find them right now.
requires that all third party libs be installed to lib/ dir and that project has appengine_config.py configured to load libs out of lib/
Python support
some non-code files in the dependencies have parens or tildas in the file name. these are rejected by appengine and cause an error
Python support
add terraform as a vendored dep
Version bump
Version bump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? (please provide any background)
WORKING WITHOUT README - ADD README IN PR FROM HX -> 22ACACIA
Update API version to updated appengine dependency. Add additional arguments to be able to parse new app engine arguments from sossity.
Dependendency management given to the tool
depwhich will be the official go built in dependency manager.In
manifest.jsonyou need to match the version of terraform you wish to upgrade to because master is branch may not be compatible with version of terraform you want to upgrade to.Google have stopped making weekly releases to gcloud and 146.0.0 has been around for a few weeks and seems to be the most stable version of gcloud yet. As a result i believe our api timeouts on deploy should be limited
What tests does this PR have?
None
How can this be tested?
In circle CI
Any tech debt?
Screenshots / Screencast
What gif best describes how you feel about this work?
Reviewer
By adding a +1 you are confirming you have...