Skip to content

Commit 3361292

Browse files
committed
fix: custom series delete crash issue #1864
1 parent 6630615 commit 3361292

File tree

2 files changed

+17
-8
lines changed

2 files changed

+17
-8
lines changed

src/dearpygui_commands.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2999,7 +2999,8 @@ delete_item(PyObject* self, PyObject* args, PyObject* kwargs)
29992999

30003000
mvUUID item = GetIDFromPyObject(itemraw);
30013001

3002-
DeleteItem((*GContext->itemRegistry), item, childrenOnly, slot);
3002+
if(item != 0)
3003+
DeleteItem((*GContext->itemRegistry), item, childrenOnly, slot);
30033004

30043005
return GetPyNone();
30053006

src/mvPythonTranslator.cpp

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -273,9 +273,11 @@ ToPyList(const std::vector<double>& value)
273273

274274
PyObject* result = PyList_New(value.size());
275275

276-
for (size_t i = 0; i < value.size(); ++i)
277-
PyList_SetItem(result, i, PyFloat_FromDouble(value[i]));
278-
276+
if(result)
277+
{
278+
for (size_t i = 0; i < value.size(); ++i)
279+
PyList_SetItem(result, i, PyFloat_FromDouble(value[i]));
280+
}
279281
return result;
280282
}
281283

@@ -284,8 +286,11 @@ ToPyList(const std::vector<std::vector<float>>& value)
284286
{
285287
PyObject* result = PyList_New(value.size());
286288

287-
for (size_t i = 0; i < value.size(); ++i)
288-
PyList_SetItem(result, i, ToPyList(value[i]));
289+
if(result)
290+
{
291+
for (size_t i = 0; i < value.size(); ++i)
292+
PyList_SetItem(result, i, ToPyList(value[i]));
293+
}
289294

290295
return result;
291296
}
@@ -295,8 +300,11 @@ ToPyList(const std::vector<std::vector<double>>& value)
295300
{
296301
PyObject* result = PyList_New(value.size());
297302

298-
for (size_t i = 0; i < value.size(); ++i)
299-
PyList_SetItem(result, i, ToPyList(value[i]));
303+
if(result)
304+
{
305+
for (size_t i = 0; i < value.size(); ++i)
306+
PyList_SetItem(result, i, ToPyList(value[i]));
307+
}
300308

301309
return result;
302310
}

0 commit comments

Comments
 (0)