Adding Forwarding reference to accessor.hpp#L57

[kobi-ca]

Hello,

Any objection if we fix this:
https://github.com/hliberacki/cpp-member-accessor/blob/master/include/accessor/accessor.hpp#L57
to be a forwarding reference parameters and use std::forward<Args>(args)... ?

If yes, I can shoot a PR. I have couple things to note:

1. It'd be with my nvidia email account (approved from NVidia Legal team to go ahead and submit PR)
2. NVidia would like to add copyright that says "NVidia..." to the modified files (header and a test file that needs tweaking) - any objection? if yes, any other options that I can take back to the legal team and discuss it?

thank you again for your reply!
Kobi

[hliberacki]

Hey Kobi,

First of all, thanks for reaching out and having interest in the library!

I have absolutely no objection to any PRs with fixes or changes - actually, they’re very welcome. Coming from NVIDIA email is not a problem at all.

As for the copyright, I have no objection either. I just want to confirm that for existing files the NVIDIA copyright would be added alongside my original copyright. Would that work on your side? If there’s anything specific you need legally, I’m flexible and happy to discuss it.

The library hasn’t changed much lately because I didn’t realize it was being used. If you or your team have other improvements or feature ideas, I’d love to chat and see how we could evolve it, or I could add features myself. If you are using another build system, feel free to reach out - that could be added as well.

Looking forward to your PR!

Thanks again for your interest,
Hubert

[kobi-ca]

Hi Hubert,

• Regarding copyright - yes, along side with the existing one.
• We are using CMake so it fits nice. We are slowly moving to conan so this is one thing we could add.

Thank you again and I will prep the PR soon.
Take care,
Kobi

[hliberacki]

Hi Kobi,

That sounds great!

We are using CMake so it fits nice. We are slowly moving to conan so this is one thing we could add.

Since it was a small addition, I went ahead and added Conan 2 support so integration on your side will be easier. PR

Once you submit your PR, I plan to create a 1.0.0 release and then open a PR to the Conan Center Index. After that is accepted, you’ll be able to pull the package directly from ConanCenter.

Just a small note: I raised the required CMake version to 3.18 in order to simplify the build and CI. I hope this won’t cause any issues, but please let me know if it might create trouble on your side.

Take care,
Hubert

[kobi-ca]

Since it was a small addition, I went ahead and added Conan 2 support so integration on your side will be easier. PR

Awesome. I will take a look

Once you submit your PR, I plan to create a 1.0.0 release and then open a PR to the Conan Center Index. After that is accepted, you’ll be able to pull the package directly from ConanCenter.

Prefect. I was about to ask you about this :)

Just a small note: I raised the required CMake version to 3.18 in order to simplify the build and CI. I hope this won’t cause any issues, but please let me know if it might create trouble on your side.

3.18 and above is great!

Take care, Hubert

Same here. thanks!

[hliberacki]

@kobi-ca your PR is merged - thanks a lot for that! :)

Now I will create a release and make a PR to Conan Center.

I'll let you know once it's ready!

[kobi-ca]

my pleasure! talk to you later!

[hliberacki]

@kobi-ca FYI,

PR in Conan Center. Lets see when it will be reviewed/merged :)

[kobi-ca]

Cool! thanks. hopefully they review it soon.