Skip to content

Commit e681a63

Browse files
authored
Merge pull request #9 from histogrammar/run-in-gpu
Run in gpu
2 parents 5d11559 + d8b2fae commit e681a63

26 files changed

+1949
-3648
lines changed

README.md

Lines changed: 29 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -25,32 +25,34 @@ Status
2525

2626
The tests are thorough.
2727

28-
* `original.py` were written during development to test all features as they were added.
29-
* `autogenerated.py` is from the language-independent testing suite ([histogrammar-multilang](https://github.com/histogrammar/histogrammar-multilang)), which provides greater coverage, value-explicitness in the test script, and cross-language agreement.
28+
* `basic.py` were written during development to test all features as they were added.
3029
* `testnumpy.py` tests numerical agreement between the conventional implementation and the Numpy implementation, which are very different. Also tests much larger datasets and infinity/NaN handling.
3130
* contrary to its name, `testnumpy.py` also compares its implementation with the literal code given in [the specification](http://histogrammar.org/docs/specification/) as well.
32-
33-
Primitive implementation is mature. Notes in the "Numpy" column are rough speedup factors for a range of tests.
34-
35-
| Primitive | Pure Python | Numpy |
36-
|:------------------|:------------|:-----------------|
37-
| Count | done | 100X |
38-
| Sum | done | 40-100X |
39-
| Average | done | 40-100X |
40-
| Deviate | done | 40-80X |
41-
| Minimize | done | 50-150X |
42-
| Maximize | done | 50-150X |
43-
| Bag | done | 1.5-2X |
44-
| Bin | done | 5-25X (100 bins) |
45-
| SparselyBin | done | 4-5X (~100 bins) |
46-
| CentrallyBin | done | 25-40X (10 bins) |
47-
| IrregularlyBin | done | 1-4X (10 plots) |
48-
| Categorize | done | 1.5X |
49-
| Fraction | done | 4-20X (100 bins) |
50-
| Stack | done | 2-12X (10 plots) |
51-
| Select | done | 4-20X (100 bins) |
52-
| Limit | done | pass-through |
53-
| Label | done | pass-through |
54-
| UntypedLabel | done | pass-through |
55-
| Index | done | pass-through |
56-
| Branch | done | pass-through |
31+
* `testrootcling.py` applies all of the Numpy tests to the ROOT/Cling implementation.
32+
* `testgpu.py` applies all of the Numpy tests to the CUDA GPU implementation.
33+
34+
Primitive implementation is mature. CUDA implementation has begun.
35+
36+
| Primitive | Pure Python | Numpy | ROOT JIT | CUDA GPU |
37+
|:------------------|:------------|:------|:---------|:-----------|
38+
| Count | done | done | done | done |
39+
| Sum | done | done | done | done |
40+
| Average | done | done | done | done |
41+
| Deviate | done | done | done | done |
42+
| Minimize | done | done | done | done |
43+
| Maximize | done | done | done | done |
44+
| Bag | done | done | done | impossible |
45+
| Bin | done | done | done | done |
46+
| SparselyBin | done | done | done | impossible |
47+
| CentrallyBin | done | done | done | done |
48+
| IrregularlyBin | done | done | done | done |
49+
| Categorize | done | done | done | impossible |
50+
| Fraction | done | done | done | done |
51+
| Stack | done | done | done | done |
52+
| Select | done | done | done | done |
53+
| Label | done | done | done | done |
54+
| UntypedLabel | done | done | done | done |
55+
| Index | done | done | done | done |
56+
| Branch | done | done | done | done |
57+
58+
* "impossible" for CUDA GPU means that the primitive requires a non-constant memory allocation (hashmaps in all three cases). There must be ways of doing this by preallocating more space than is needed, but I'm not going to get into that for this round.

histogrammar/__init__.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
from histogrammar.primitives.deviate import *
2727
from histogrammar.primitives.fraction import *
2828
from histogrammar.primitives.irregularlybin import *
29-
from histogrammar.primitives.limit import *
3029
from histogrammar.primitives.minmax import *
3130
from histogrammar.primitives.select import *
3231
from histogrammar.primitives.sparselybin import *

0 commit comments

Comments
 (0)