Skip to content

Commit 0973929

Browse files
committed
[SPARK-47143][CONNECT][TESTS] Improve ArtifactSuite to use unique MavenCoordinates
### What changes were proposed in this pull request? This PR aims to improve `ArtifactSuite` to use unique `MavenCoordinate`s. ### Why are the changes needed? `MavenCoordinate("my.great.lib", "mylib", "0.1")` is used in many places. However, `ArtifactSuite` uses it differently to check transitive dependencies. Sometimes, the other suites' leftover causes a test case failure. We had better use unique artifact name in this case in order to isolate completely. ``` $ git grep 'MavenCoordinate("my.great.lib", "mylib", "0.1")' common/utils/src/test/scala/org/apache/spark/util/MavenUtilsSuite.scala: val main = new MavenCoordinate("my.great.lib", "mylib", "0.1") common/utils/src/test/scala/org/apache/spark/util/MavenUtilsSuite.scala: val main = new MavenCoordinate("my.great.lib", "mylib", "0.1") common/utils/src/test/scala/org/apache/spark/util/MavenUtilsSuite.scala: val main = new MavenCoordinate("my.great.lib", "mylib", "0.1") common/utils/src/test/scala/org/apache/spark/util/MavenUtilsSuite.scala: val main = new MavenCoordinate("my.great.lib", "mylib", "0.1") common/utils/src/test/scala/org/apache/spark/util/MavenUtilsSuite.scala: val main = MavenCoordinate("my.great.lib", "mylib", "0.1") connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/application/ReplE2ESuite.scala: val main = MavenCoordinate("my.great.lib", "mylib", "0.1") core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala: val main = MavenCoordinate("my.great.lib", "mylib", "0.1") core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala: val main = MavenCoordinate("my.great.lib", "mylib", "0.1") core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala: val main = MavenCoordinate("my.great.lib", "mylib", "0.1") core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala: val main = MavenCoordinate("my.great.lib", "mylib", "0.1") ``` ### Does this PR introduce _any_ user-facing change? No. This is a test-case only change. ### How was this patch tested? Manual review because this passed the CIs in general. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#45230 from dongjoon-hyun/SPARK-47143. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
1 parent d466c0b commit 0973929

File tree

1 file changed

+7
-5
lines changed
  • connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/client

1 file changed

+7
-5
lines changed

connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/client/ArtifactSuite.scala

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -273,14 +273,16 @@ class ArtifactSuite extends ConnectFunSuite with BeforeAndAfterEach {
273273
}
274274

275275
test("resolve ivy") {
276-
val main = new MavenCoordinate("my.great.lib", "mylib", "0.1")
277-
val dep = "my.great.dep:mydep:0.5"
276+
val main = new MavenCoordinate("my.artifactsuite.lib", "mylib", "0.1")
277+
val dep = "my.artifactsuite.dep:mydep:0.5"
278278
IvyTestUtils.withRepository(main, Some(dep), None) { repo =>
279279
val artifacts =
280-
Artifact.newIvyArtifacts(URI.create(s"ivy://my.great.lib:mylib:0.1?repos=$repo"))
281-
assert(artifacts.exists(_.path.toString.contains("jars/my.great.lib_mylib-0.1.jar")))
280+
Artifact.newIvyArtifacts(URI.create(s"ivy://my.artifactsuite.lib:mylib:0.1?repos=$repo"))
281+
assert(
282+
artifacts.exists(_.path.toString.contains("jars/my.artifactsuite.lib_mylib-0.1.jar")))
282283
// transitive dependency
283-
assert(artifacts.exists(_.path.toString.contains("jars/my.great.dep_mydep-0.5.jar")))
284+
assert(
285+
artifacts.exists(_.path.toString.contains("jars/my.artifactsuite.dep_mydep-0.5.jar")))
284286
}
285287

286288
}

0 commit comments

Comments
 (0)