Skip to content

fix(markdown) Ignore mid_word underscores #4342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+10 −2
Open

fix(markdown) Ignore mid_word underscores #4342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b42703e
fix(markdown) Ignore mid_word underscores
danvk Nov 11, 2025
868e6cd
add note to CHANGES.md
danvk Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ Core Grammars:
- enh(json) add json5 support [Kerry Shetline][]
- fix(css) `unicode-range` parsing, issue #4253 [Kerry Shetline][]
- fix(csharp) Support digit separators [te-ing][]
- fix(markdown) Ignore mid_word underscores, issue #4279 [Dan Vanderkam]

Documentation:

Expand Down Expand Up @@ -55,6 +56,7 @@ CONTRIBUTORS
[te-ing]: https://github.com/te-ing
[Anthony Martin]: https://github.com/anthony-c-martin
[NriotHrreion]: https://github.com/NriotHrreion
[Dan Vanderkam]: https://github.com/danvk


## Version 11.11.1
Expand Down
4 changes: 2 additions & 2 deletions src/languages/markdown.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,8 +156,8 @@ export default function(hljs) {
end: /\*/
},
{
begin: /_(?![_\s])/,
end: /_/,
begin: /(?<![a-zA-Z0-9])_(?![_\s])/,
end: /_(?![a-zA-Z0-9])/,
relevance: 0
}
]
Expand Down
3 changes: 3 additions & 0 deletions test/markup/markdown/bold_italics.expect.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,6 @@ _ not italic_
<span class="hljs-quote">&gt; * One (this point is italic)</span>
<span class="hljs-quote">&gt; * Two</span>
<span class="hljs-quote">&gt; * Three</span>

No italics mid_word underscores.
But italics for <span class="hljs-emphasis">_full_word_</span> with underscores.
3 changes: 3 additions & 0 deletions test/markup/markdown/bold_italics.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,6 @@ _ not italic_
> * One (this point is italic)
> * Two
> * Three

No italics mid_word underscores.
But italics for _full_word_ with underscores.