Skip to content

fix(javascript): add self to BUILT_IN_VARIABLES #4341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −2
Open

fix(javascript): add self to BUILT_IN_VARIABLES #4341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/languages/lib/ecmascript.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,7 @@ export const BUILT_IN_VARIABLES = [
"localStorage",
"sessionStorage",
"module",
"self",
"global" // Node.js
];

Expand Down
3 changes: 2 additions & 1 deletion test/markup/javascript/built-in.expect.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<span class="hljs-keyword">let</span> bi = <span class="hljs-title class_">BigInt</span>(<span class="hljs-string">&#x27;1&#x27;</span>);
<span class="hljs-keyword">let</span> inf = <span class="hljs-title class_">Infinity</span>
<span class="hljs-title class_">Number</span>(<span class="hljs-literal">undefined</span>)
<span class="hljs-keyword">let</span> today = <span class="hljs-keyword">new</span> <span class="hljs-title class_">Date</span>()
<span class="hljs-keyword">let</span> today = <span class="hljs-keyword">new</span> <span class="hljs-title class_">Date</span>()
<span class="hljs-variable language_">self</span>
4 changes: 3 additions & 1 deletion test/markup/javascript/built-in.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
let bi = BigInt('1');
let inf = Infinity
Number(undefined)
let today = new Date()
let today = new Date()
self