Skip to content

Remove unused logging code #1470

@schneems

Description

@schneems

From #1469 (comment), it was brought up that I removed a logging call and didn't replace it. This logging functionality is not being used, so it's presence is causing confusion and it adds no value.

We should:

  • Remove all calls to log() in the codebase
  • Remove log function
  • Remove the internals that only log uses, such as log_internal
  • Do an audit to see if any other functionality to support logging is no longer used by any other codepaths, for example the value set here@id = Digest::SHA1.hexdigest("#{Time.now.to_f}-#{rand(1000000)}")[0..10] is being consumed by the logger. If it's not being used anywhere else we can get rid of it.

We need to take care to not break builds. We have a lot of integration tests, but they're not comprehensive. A one-in-a-million occurrence happens pretty frequently around here. Ruby does not give strong static guarantees.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions