Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 4, 2025

Repository uses pnpm exclusively but contained package-lock.json from npm and had inconsistent documentation referencing npm.

Changes

  • Removed package-lock.json
  • Updated .gitignore to block package-lock.json and yarn.lock from future commits
  • Updated README.md installation instructions from npm install to pnpm add
  • Updated .github/copilot-instructions.md to explicitly enforce pnpm-only usage with stricter guidelines

Only pnpm-lock.yaml remains as the lock file, and all documentation now consistently references pnpm as the sole package manager.

Original prompt

I only want to use pnpm in this repo, remove any other lock file


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI self-assigned this Nov 4, 2025
@hckhanh
Copy link
Owner

hckhanh commented Nov 4, 2025

@copilot Update instruction to make sure only pnpm is used

Copilot AI changed the title [WIP] Remove other lock files to use pnpm only Remove npm lock file and prevent future non-pnpm lock files Nov 4, 2025
Copilot finished work on behalf of hckhanh November 4, 2025 09:17
Copilot AI requested a review from hckhanh November 4, 2025 09:17
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (a8bffa5) to head (d7c26e8).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #60   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          245       245           
  Branches        82        82           
=========================================
  Hits           245       245           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hckhanh hckhanh marked this pull request as ready for review November 4, 2025 09:20
Copilot AI review requested due to automatic review settings November 4, 2025 09:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 4, 2025

CodSpeed Performance Report

Merging #60 will not alter performance

Comparing copilot/remove-other-lock-files-again (d7c26e8) with main (a8bffa5)

Summary

✅ 64 untouched

Copy link
Contributor Author

Copilot AI commented Nov 4, 2025

@copilot Update instruction to make sure only pnpm is used

Updated both README.md and copilot-instructions.md to enforce pnpm-only usage:

  • Changed installation instructions from npm install to pnpm add
  • Made package manager requirements more explicit in copilot-instructions.md

Commit: d7c26e8

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 4, 2025

Copilot AI changed the title Remove npm lock file and prevent future non-pnpm lock files Enforce pnpm-only usage: Remove npm lock file and update documentation Nov 4, 2025
Copilot AI requested a review from hckhanh November 4, 2025 09:21
Copilot finished work on behalf of hckhanh November 4, 2025 09:21
@hckhanh hckhanh merged commit e029977 into main Nov 4, 2025
7 checks passed
@hckhanh hckhanh deleted the copilot/remove-other-lock-files-again branch November 4, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants