Simplify formatNumber logic

Refactored `formatNumber` to reduce redundancy and improve readability. Combined conditions to streamline the implementation and adjusted handling of null and string inputs. Updated fallback behavior to maintain correctness and consistency.

test(config): refine Vitest exclusions

Added specific exclusions for `src/index.ts` and `src/format/index.ts` in both test and coverage settings. Improves test accuracy by omitting irrelevant files from coverage metrics.

Author: hckhanh

.changeset/wide-things-dig.md

@@ -0,0 +1,5 @@
+---
+"vn-number": patch
+---
+
+Optimize logic of `formatNumber` function

src/format/number.ts

@@ -10,21 +10,13 @@ function formatNumber(
   formatter: Intl.NumberFormat,
   fallbackValue: string,
 ) {
-  if (
-    (typeof number === 'number' && !Number.isNaN(number)) ||
-    typeof number === 'bigint'
-  ) {
-    return formatter.format(number)
-  } else if (typeof number === 'string') {
-    try {
-      const num = Number(number)
-      return Number.isNaN(num) ? fallbackValue : formatter.format(num)
-    } catch {
-      return fallbackValue
-    }
-  } else {
-    return fallbackValue
-  }
+  if (number == null) return fallbackValue
+  if (typeof number === 'bigint') return formatter.format(number)
+  if (typeof number === 'number')
+    return Number.isNaN(number) ? fallbackValue : formatter.format(number)
+
+  const num = Number(number)
+  return Number.isNaN(num) ? fallbackValue : formatter.format(num)
 }
 
 const VN_NUMBER_FORMATTER = new Intl.NumberFormat('vi-VN')

vitest.config.mts

@@ -8,9 +8,19 @@ import {
 export default defineConfig({
   plugins: [codspeed()],
   test: {
-    exclude: [...defaultExclude, 'tsdown.config.*'],
+    exclude: [
+      ...defaultExclude,
+      'tsdown.config.*',
+      'src/index.ts',
+      'src/format/index.ts',
+    ],
     coverage: {
-      exclude: [...coverageConfigDefaults.exclude, 'tsdown.config.*'],
+      exclude: [
+        ...coverageConfigDefaults.exclude,
+        'tsdown.config.*',
+        'src/index.ts',
+        'src/format/index.ts',
+      ],
     },
   },
 })