Make ‘cabal exec’ not pass -package-env to called executable

It never did previously and it’s a bug that it started to.

Author: sergv

cabal-install/src/Distribution/Client/CmdExec.hs

@@ -200,16 +200,13 @@ execAction flags extraArgs globalFlags = do
 
       ( if envFilesSupported
           then withTempEnvFile verbosity baseCtx buildCtx buildStatus
-          else \f ->
-            if programIsConfiguredCompiler
-              then f environmentPackageArgs []
-              else f [] []
+          else \f -> f environmentPackageArgs []
         )
         $ \argOverrides envOverrides -> do
           let program' =
                 withOverrides
                   envOverrides
-                  argOverrides
+                  (if programIsConfiguredCompiler then argOverrides else [])
                   program
               invocation = programInvocation program' args
               dryRun =

cabal-testsuite/PackageTests/ExecCommand/Main.hs

@@ -0,0 +1,13 @@
+
+module Main (main) where
+
+import System.Environment
+import System.Exit
+import System.IO
+
+main :: IO ()
+main = do
+  args <- getArgs
+  case args of
+    ["--required", "foo"] -> pure ()
+    other -> die $ "Unexpected arguments: " ++ show other

cabal-testsuite/PackageTests/ExecCommand/cabal.out

@@ -0,0 +1,9 @@
+# cabal v2-build
+Resolving dependencies...
+Build profile: -w ghc-<GHCVER> -O1
+In order, the following will be built:
+ - my-0.1 (exe:my-executable) (first run)
+Configuring executable 'my-executable' for my-0.1...
+Preprocessing executable 'my-executable' for my-0.1...
+Building executable 'my-executable' for my-0.1...
+# cabal v2-exec

cabal-testsuite/PackageTests/ExecCommand/cabal.project

@@ -0,0 +1 @@
+packages: .

cabal-testsuite/PackageTests/ExecCommand/cabal.test.hs

@@ -0,0 +1,18 @@
+
+import Test.Cabal.Prelude
+
+main :: IO ()
+main = cabalTest $ do
+  cabal "v2-build" ["my:exe:my-executable"]
+
+  withPlan $ do
+    exePath <- planExePath "my" "my-executable"
+
+    -- The test is to check that we’re not acceidentally passing more
+    -- than expected.
+    --
+    -- Target executable may not accept any extra option cabal may pass.
+    -- Or it may and it would lead to incorrect results and lengthy
+    -- debugging, which is worse.
+    cabal "v2-exec" [exePath, "--", "--required", "foo"]
+

cabal-testsuite/PackageTests/ExecCommand/my.cabal

@@ -0,0 +1,10 @@
+cabal-version:  3.0
+name:           my
+version:        0.1
+license:        BSD-3-Clause
+build-type:     Simple
+
+executable my-executable
+  main-is:            Main.hs
+  build-depends:      base
+  default-language:   Haskell2010