client streaming + http redirect result into runtime exception

[domenkozar]

If an http endpoint returns a redirect (for example http -> https upgrade), streaming client errors out:

HasClient @StreamBody
CallStack (from HasCallStack):
  error, called at src/Servant/Client/Core/Internal/HasClient.hs:550:44 in servant-client-core-0.15-KKVc3oxuLh47HhicA3CWtB:Servant.Client.Core.Internal.HasClient                                                                                                                                                     

https://github.com/haskell-servant/servant/blob/master/servant-client-core/src/Servant/Client/Core/Internal/HasClient.hs#L550

[phadej]

Looks like it errors out *always*. I forgot to write an implementation :/

…

Sent from my iPhone

On 28 Nov 2018, at 16.08, Domen Kožar ***@***.***> wrote: If an http endpoint returns a redirect (for example http -> https upgrade), streaming client errors out: HasClient @StreamBody CallStack (from HasCallStack): error, called at src/Servant/Client/Core/Internal/HasClient.hs:550:44 in servant-client-core-0.15-KKVc3oxuLh47HhicA3CWtB:Servant.Client.Core.Internal.HasClient https://github.com/haskell-servant/servant/blob/master/servant-client-core/src/Servant/Client/Core/Internal/HasClient.hs#L550 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[phadej]

I won't be able to look at this issue this week. But if someone can make a patch, then I'll happily review it. (and make the release after merge).

[domenkozar]

There's absolutely no hurry from my side.

[domenkozar]

This is now blocking cachix/cachix#163

[domenkozar]

Note that this has to be reopened, we haven't fixed the redirect use/test case yet.

[phadej]

Streaming + redirect ought to use something like https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/100

Otherwise I don't see how to stream body only once to final target