Skip to content

Fix horizontal scrolling / width on mobile #246

@andys8

Description

@andys8
Contributor

The video shows that the start page haskell.org behaves glitchy on mobile. You can scroll horizontally, but you shouldn't be able to. This doesn't result in a terrible user experience, but still is an issue that should be avoided.

Record_2023-02-03-11-39-59.mp4

I tested with Android 13 and latest Chrome and Kiwi Browser on a OnePlus 8.

Activity

andys8

andys8 commented on Feb 3, 2023

@andys8
ContributorAuthor

It's noteworthy that there is an open PR mentioning improvements of the landing page. There is a chance this PR would solve the demonstrated issue, but it has to be tested to know if this is the case or not.

#242

tomjaguarpaw

tomjaguarpaw commented on Feb 3, 2023

@tomjaguarpaw
Collaborator

Interesting, thanks. I'll investigate that fix.

tomjaguarpaw

tomjaguarpaw commented on Feb 3, 2023

@tomjaguarpaw
Collaborator

As far as i can tell #242 seems to make things worse! I think the cause is the >> on the right hand side of the Testimonials scroller.

tomjaguarpaw

tomjaguarpaw commented on Feb 3, 2023

@tomjaguarpaw
Collaborator

Yeah, #242 does make things worse, because it forces the "Haskell logo, Haskell, An advanced, purely functional programming language" block to be on the same horizontal level as "Declarative, statically typed code, primes code, Get Started" block, making the screen wider. The status quo is that on narrow screens the first block appears above the second.

andys8

andys8 commented on Feb 3, 2023

@andys8
ContributorAuthor

How would you suggest dealing with this issue? Fixing the current version independently of #242 and making sure that #242 only gets merged if it doesn't make it worse / break it again? Or work on #242 directly?

tomjaguarpaw

tomjaguarpaw commented on Feb 3, 2023

@tomjaguarpaw
Collaborator

This issue seems to be independent of #242 so I suggest just finding a fix that addresses the reason that the >> falls off the screen.

andys8

andys8 commented on Feb 3, 2023

@andys8
ContributorAuthor

I wanted to start taking a look, but buildAndWatch ended up in:

/nix/store/2md452mq5labdcxlsc5gfik97dhxabbr-haskell-org-0.1.0.0
Removing _site...
Removing _cache...
Removing _cache/tmp...
Initialising...
  Creating store...
  Creating provider...
  Running rules...
Checking for out-of-date items
Compiling
  updated 2015-11-10-Haskell-Org-Board-Resolution.pdf
  [ERROR] _cache/a98f5fd1dec8ada591e76ae4112817f9 for Hakyll.Core.Resource.Provider.MetadataCache/community.markdown/body: Store.set: invalid argument (invalid byte sequence)

Is there an explanation or is this a reason to open an issue?

TikhonJelvis

TikhonJelvis commented on Feb 3, 2023

@TikhonJelvis
Member

@andys8 That looks related to #29 :/. Could you try explicitly setting the locale before running the script?

LC_ALL=C.UTF-8 ./buildAndWatch

I though that #236 should have fixed that, but apparently not. I'll need to take another look into why this is a problem and how we can fix it more robustly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @TikhonJelvis@tomjaguarpaw@andys8

      Issue actions

        Fix horizontal scrolling / width on mobile · Issue #246 · haskell-infra/www.haskell.org