-
Notifications
You must be signed in to change notification settings - Fork 34
Description
Version 0.3.6 is not PVP compliant.
See the diff here liyang/thyme@0.3.5.4...master.
For example the signature of mkUTCTime
has changed from mkUTCTime :: Day -> DiffTime -> UTCTime
to mkUTCTime :: Year -> Month -> DayOfMonth -> Hour -> Minute -> Double -> UTCTime
. The API has expanded as well.
I would suggest releasing a 0.4 version to hackage (based on the changes on master
) and blacklisting the 0.3.6 version. Additionally we should create a 0.3.7
that just updates package version bounds without any code changes.
[1] https://hackage.haskell.org/package/thyme-0.3.6/docs/Data-Thyme-Clock.html#v:mkUTCTime
[2] https://hackage.haskell.org/package/thyme-0.3.5.5/docs/Data-Thyme-Time-Core.html#v:mkUTCTime
I uploaded thyme-0.4 and deprecated 0.3.6
@fumieval
A compliant working version of the 0.3 series of releases would be useful to existing users of the library.