Fix for desired_auto_created_endpoints incorrect update (#15720) (#11119)

[upstream:41a39ce69b8dafa59f8322b0753ca20b264e4916]

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

.changelog/15720.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+memorystore: fixed an issue where a permadiff on `desired_auto_created_endpoints` caused the `google_memorystore_instance` resource to recreated.
+```

google-beta/services/memorystore/resource_memorystore_instance.go

@@ -54,6 +54,20 @@ import (
 	"google.golang.org/api/googleapi"
 )
 
+func memorystoreInstancedDesiredAutoConnectionsDiffSuppress(k, old, new string, d *schema.ResourceData) bool {
+	// Suppress diff wis to handle an edge case where desired_auto_created_endpoints in addtion to desired_psc_auto_connections are both set with same values
+	// this is due to how the api reponds when mode is set to CLUSTER_DISABLED and desired_psc_auto_connections is set.
+	log.Printf("[DEBUG] desired_auto_created_endpoints is set in state but not in config, supressing force new recreate")
+
+	oldAuto, newAuto := d.GetChange("desired_auto_created_endpoints")
+
+	if reflect.DeepEqual(oldAuto, newAuto) && !tpgresource.IsEmptyValue(reflect.ValueOf(oldAuto)) && !tpgresource.IsEmptyValue(reflect.ValueOf(newAuto)) {
+		return true
+	}
+
+	return false
+}
+
 var (
 	_ = bytes.Clone
 	_ = context.WithCancel
@@ -998,10 +1012,11 @@ projects/{project_id}/global/networks/{network_id}.`,
 				ConflictsWith: []string{},
 			},
 			"desired_auto_created_endpoints": {
-				Type:        schema.TypeList,
-				Optional:    true,
-				ForceNew:    true,
-				Description: `Immutable. User inputs for the auto-created endpoints connections.`,
+				Type:             schema.TypeList,
+				Optional:         true,
+				ForceNew:         true,
+				DiffSuppressFunc: memorystoreInstancedDesiredAutoConnectionsDiffSuppress,
+				Description:      `Immutable. User inputs for the auto-created endpoints connections.`,
 				Elem: &schema.Resource{
 					Schema: map[string]*schema.Schema{
 						"network": {