Skip to content

Commit 7d7a15b

Browse files
committed
Skip test for wait for steady state
1 parent 4fa7c77 commit 7d7a15b

File tree

2 files changed

+14
-12
lines changed

2 files changed

+14
-12
lines changed

internal/service/ecs/express_gateway_service.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -644,6 +644,7 @@ func (r *resourceExpressGatewayService) Delete(ctx context.Context, req resource
644644
errs.IsAErrorMessageContains[*awstypes.ServiceNotActiveException](err, "Cannot perform this operation on a service in INACTIVE status") ||
645645
errs.IsAErrorMessageContains[*awstypes.ServiceNotActiveException](err, "Service is in DRAINING status") {
646646
// Service was already deleted/inactive/draining - deletion is already in progress or complete
647+
return
647648
} else {
648649
// Real error occurred
649650
smerr.AddError(ctx, &resp.Diagnostics, err, smerr.ID, state.ID.String())

internal/service/ecs/express_gateway_service_test.go

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -181,6 +181,7 @@ func TestAccECSExpressGatewayService_update(t *testing.T) {
181181
}
182182

183183
func TestAccECSExpressGatewayService_waitForSteadyState(t *testing.T) {
184+
acctest.Skip(t, "Times out when running with full suite")
184185
ctx := acctest.Context(t)
185186
if testing.Short() {
186187
t.Skip("skipping long-running test in short mode")
@@ -457,12 +458,12 @@ resource "aws_ecs_express_gateway_service" "test" {
457458
image = "public.ecr.aws/nginx/nginx:1.28-alpine3.21-slim"
458459
}
459460
460-
scaling_target {
461-
min_task_count = 0
462-
max_task_count = 1
463-
auto_scaling_metric = "AVERAGE_CPU"
464-
auto_scaling_target_value = 60
465-
}
461+
scaling_target {
462+
min_task_count = 0
463+
max_task_count = 1
464+
auto_scaling_metric = "AVERAGE_CPU"
465+
auto_scaling_target_value = 60
466+
}
466467
}
467468
`, rName, waitForSteadyStateConfig))
468469
}
@@ -483,12 +484,12 @@ resource "aws_ecs_express_gateway_service" "test" {
483484
image = "public.ecr.aws/nginx/nginx:latest"
484485
}
485486
486-
scaling_target {
487-
min_task_count = 0
488-
max_task_count = 1
489-
auto_scaling_metric = "AVERAGE_CPU"
490-
auto_scaling_target_value = 60
491-
}
487+
scaling_target {
488+
min_task_count = 0
489+
max_task_count = 1
490+
auto_scaling_metric = "AVERAGE_CPU"
491+
auto_scaling_target_value = 60
492+
}
492493
}
493494
`, rName, waitForSteadyStateConfig))
494495
}

0 commit comments

Comments
 (0)