Remove ember-cli-clipboard
#3098
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
hashicc
force-pushed
the
remove-ember-cli-clipboard
branch
from
75a18ce to
2121925
Compare
hashicc
commented
Nov 26, 2025
| <CopyButton | ||
| @text={{@copyText}} | ||
| <Hds::Copy::Button | ||
| @text='Copy code' |
Collaborator
Author
There was a problem hiding this comment.
@text is a different argument on Hds::Copy::Button (inner text) than the ember-cli-clipboard CopyButton (the text to copy)
hashicc
force-pushed
the
remove-ember-cli-clipboard
branch
from
2121925 to
8105022
Compare
hashicc
commented
Nov 26, 2025
| assert.dom(menuDividerSelector).doesNotExist(); | ||
|
|
||
| await click(copyButtonSelector); | ||
| await onCopyPromise; |
Collaborator
Author
There was a problem hiding this comment.
Test was failing in CI. After checking locally and refreshing the test it appears that there was a race condition. This promise guarantees that the callback was called before checking the value. I think it's still good to have the explicit assert since it's more explicit than the promise succeeding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes
ember-cli-clipboardand the singleCopyButtonusage in our rose code editor toolbar.ember-cli-clipboardis not compatible with vite currently: Incompatible with Vite due to transitive dep (ember-get-config) which uses require jkusa/ember-cli-clipboard#432Hds::Copy::ButtonRose::CodeEditorwhich uses the copy button will at some point be replaced with theHds::CodeEditor(see ReplaceRose::CodeEditorwithHds::CodeEditor#2679)Screenshots (if appropriate)
Before
After
How to Test
main(eg:mainvercel deployment) and compare against this branch (eg: this branch's vercel deployment)Checklist
a11y-testslabel to run a11y audit tests if neededPCI review checklist
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.