chore: remove workarounds previously implemented (#245)

Signed-off-by: Nathan Klick <nathan@swirldslabs.com>

Author: nathanklick

dev/scripts/direct-install.sh

@@ -68,8 +68,6 @@ function setup_node_all() {
     ls_path "${pod}" "${HAPI_PATH}/data/keys/"
     set_permission "${pod}" "${HAPI_PATH}"
 
-    # TODO remove set_application_env after 0.5.0 docker image is published
-    set_application_env "${pod}"
     unzip_build "${pod}"
   done
 }

dev/scripts/helper.sh

@@ -773,21 +773,3 @@ function reset_node_all() {
 
   return "${EX_OK}"
 }
-
-# TODO remove set_application_env after 0.5.0 docker image is published
-function set_application_env() {
-   local pod="${1}"
-
-    echo ""
-    echo "Populating values in /etc/network-node/application.env ${pod}"
-    echo "-----------------------------------------------------------------------------------------------------"
-
-    if [ -z "${pod}" ]; then
-      echo "ERROR: 'reset_nmt' - pod name is required"
-      return "${EX_ERR}"
-    fi
-
-    # best effort clean up of docker env
-    "${KCTL}" exec "${pod}" -c root-container -- bash -c "echo APP_HOME=/opt/hgcapp/services-hedera/HapiApp2.0 > /etc/network-node/application.env" || true
-    return "${EX_OK}"
-}

docker/ubi8-init-java17/Dockerfile

@@ -107,9 +107,6 @@ RUN chmod -R +x /etc/network-node/entrypoint.sh && \
 
 RUN mkdir -p /etc/network-node && \
     touch /etc/network-node/application.env && \
-    echo "APP_HOME=/opt/hgcapp/services-hedera/HapiApp2.0" >> /etc/network-node/application.env && \
-    echo "JAVA_HOME=\"${JAVA_HOME}\"" >> /etc/network-node/java.env && \
-    echo "PATH=\"${PATH}\"" >> /etc/network-node/java.env && \
     chown -R 2000:2000 /etc/network-node
 
 # Expose TCP/UDP Port Definitions

docker/ubi8-init-java17/network-node.service

@@ -8,8 +8,7 @@ Restart=no
 User=hedera
 Group=hedera
 
-PassEnvironment=JAVA_HOME PATH APP_HOME
-EnvironmentFile=/etc/network-node/java.env
+PassEnvironment=JAVA_HOME JAVA_OPTS JAVA_HEAP_MIN JAVA_HEAP_MAX PATH APP_HOME
 EnvironmentFile=/etc/network-node/application.env
 
 WorkingDirectory=/opt/hgcapp/services-hedera/HapiApp2.0