Adding comment returns 500 Internal Server error

[nickyhuyskens]

Prerequsities

• [ x] I'm on the latest version of the plugin - yes, both the default and develop branch give this issue
• [ x] I've installed the required dependencies
• [ x] I've run :h gitlab.nvim.troubleshooting and followed the steps there

Setup Configuration and Environment

Default configuration with url and token set as environment variables

Bug Description

Whenever I add a comment on a diff (cc followed by typing the comment and then ZZ), I get an error below with the message: gitlab.nvim: Could not create discussion: POST https://git.company.somewhere/api/v4/projects/3319/merge_requests/507/discussions: 500 {message: 500 Internal Server Error}

As it is a company managed gitlab, I do not have access to its logs to see what the internal server error is.
The gitlab version is: GitLab Community Edition v17.5.5

My account is a managed ldap account.

Logs from the gitlab.nvim.log file:

`
-- REQUEST TO GITLAB --
POST /api/v4/projects/3319/merge_requests/507/discussions HTTP/1.1
Host: company.somewhere
Accept: application/json
Content-Type: application/json
Private-Token: REDACTED
User-Agent: go-gitlab

{"body":"test","position":{"base_sha":"7a0e2ade58e98f04ac28c7e487d43d18178bcab2","head_sha":"9176a8a2f380184310ddb2484d529c251449d92b","start_sha":"7a0e2ade58e98f04ac28c7e487d43d18178bcab2","new_path":"file/pom.xml","old_path":"","position_type":"text","old_line":66}}

-- RESPONSE FROM GITLAB --
HTTP/1.1 500 Internal Server Error
Content-Length: 39
Cache-Control: no-cache
Connection: keep-alive
Content-Type: application/json
Date: Thu, 20 Mar 2025 10:56:06 GMT
Server: nginx
Strict-Transport-Security: max-age=63072000
Vary: Origin
X-Gitlab-Meta: {"correlation_id":"01JPSK4CXTC5PAC107FVWY4KMG","version":"1"}
X-Request-Id: 01JPSK4CXTC5PAC107FVWY4KMG
X-Runtime: 0.132080

{"message":"500 Internal Server Error"}

-- RESPONSE FROM GO SERVER --
HTTP/0.0 500 Internal Server Error
Content-Length: 173
Content-Type: application/json

{"message":"Could not create discussion","details":"POST https://git.company.somewhere/api/v4/projects/3319/merge_requests/507/discussions: 500 {message: 500 Internal Server Error}"}
`

[aravind2612krishna]

I'm facing the same issue {"message":"500 Internal Server Error"}

[coderkun]

I see a bunch of errors in the GitLab logs but am not sure which ones to post. The amount of logs is a bit overwhelming tbh.

[nickyhuyskens]

Extra info: I can confirm that the bug is introduced in the latest commit.
I changed my dependency to use tag = "v3.3.11" instead of branch in lazy and creating comments work again!

[cenk1cenk2]

I think this happens because of position.old_path is left empty while sending the request.

{
  "body": "asdf",
  "position": {
    "base_sha": "95c532e4759bde19891a7d8b05bca53840fb9ff8",
    "head_sha": "f88adec08bd1dccb65b0597dd76cc6e20a111583",
    "start_sha": "95c532e4759bde19891a7d8b05bca53840fb9ff8",
    "position_type": "text",
    "new_path": "internal/controller/common.go",
    "old_path": "",
    "old_line": 22,
    "line_range": {
      "start": { "line_code": "c547f7da1e7432c02c92623c6384f2abc9eb337d_21_0", "type": "old" },
      "end": { "line_code": "c547f7da1e7432c02c92623c6384f2abc9eb337d_22_0", "type": "old" }
    }
  }
}

If do the same request externally without the position.old_path is just works.

[jakubbortlik]

Hi all, I believe my PR #485 may be related to this issue but I don't have the time to test or investigate it any further at the moment.

[jakubbortlik]

I think this happens because of position.old_path is left empty while sending the request.

{
  "body": "asdf",
  "position": {
    "base_sha": "95c532e4759bde19891a7d8b05bca53840fb9ff8",
    "head_sha": "f88adec08bd1dccb65b0597dd76cc6e20a111583",
    "start_sha": "95c532e4759bde19891a7d8b05bca53840fb9ff8",
    "position_type": "text",
    "new_path": "internal/controller/common.go",
    "old_path": "",
    "old_line": 22,
    "line_range": {
      "start": { "line_code": "c547f7da1e7432c02c92623c6384f2abc9eb337d_21_0", "type": "old" },
      "end": { "line_code": "c547f7da1e7432c02c92623c6384f2abc9eb337d_22_0", "type": "old" }
    }
  }
}

If do the same request externally without the position.old_path is just works.

Hi @cenk1cenk2, how do you "do the same request externally"? With curl or something? Can you share a snippet with an example? That could help debug (this and other issues). Thanks!

[harrisoncramer]

Looking at the changes between the two most recent releases (v3.3.11...v3.3.12), my suspicion is that this PR is likely the issue, as it changes the payload for comment creation.

However, I'm not able to replicate for myself locally. If someone who is having these issues would be willing to try the plugin on this branch and let me know if that resolves things, that'd be helpful: #488

[jakubbortlik]

Looking at the changes between the two most recent releases (v3.3.11...v3.3.12), my suspicion is that this PR is likely the issue, as it changes the payload for comment creation.

Hi @harrisoncramer, I think the PR you mention is itself not the problem - it removed the empty string check in cmd/app/comment_helpers.go, but at the same time, it made sure that the old_file_name was always set in lua/gitlab/reviewer/init.lua. The problem really happened later when #476 was merged and made it possible again to have the old_file_name as an empty string (on the Lua side). I've mentioned before that #485 is supposed to fix that.

But this applies just to the develop branch, I'm not sure about main.

[harrisoncramer]

I'd like to get main back into a working state -- @jakubbortlik if you know the issue and have a moment to fix, please submit a PR! Otherwise (in a couple of days) I'm going to have to revert the most recent release.

[sergey-arkhipov]

Same issue.
This is the basic functionality. :(
Rollback to version v3.3.11

gitlab.nvim: Could not create discussion: POST https://gitlab.ru/api/v4/projects/164/merge_requests/610/discussions: 500 {message: 500 Internal Server Error}

[jakubbortlik]

I'd like to get main back into a working state -- @jakubbortlik if you know the issue and have a moment to fix, please submit a PR! Otherwise (in a couple of days) I'm going to have to revert the most recent release.

Sorry, I haven't been more active on this. I've had a nasty flue recently and the whole family was upside down. I'll try to prepare a fix today or tomorrow.

[jakubbortlik]

I'd like to get main back into a working state -- @jakubbortlik if you know the issue and have a moment to fix, please submit a PR! Otherwise (in a couple of days) I'm going to have to revert the most recent release.

@harrisoncramer As far as I can tell, #485 fixes the issue with 500 Internal Server Error. But it's based off the develop branch, as recommended in gitlab.nvim/.github/CONTRIBUTING.md. Should I rabase it on main and change the merge target to main?