don't encode error if the response has been committed (#345)

jcox250 · web-flow · commit a81d9c76ec60 · 2024-07-22T17:47:29.000+01:00
diff --git a/transport/handlers.go b/transport/handlers.go
@@ -37,7 +37,10 @@ func NewUnaryHandler(e endpoint.Endpoint, dec decodeRequestFunc, enc encodeRespo
 		}
 
 		if err := enc(ctx, w, resp); err != nil {
-			return errorEncoder(c, err)
+			if !c.Response().Committed {
+				return errorEncoder(c, err)
+			}
+			l.Error("response headers already written", "err", err)
 		}
 		return nil
 	}

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,10 @@ func NewUnaryHandler(e endpoint.Endpoint, dec decodeRequestFunc, enc encodeRespo`
`37`	`37`	`}`
`38`	`38`
`39`	`39`	`if err := enc(ctx, w, resp); err != nil {`
`40`		`- return errorEncoder(c, err)`
	`40`	`+ if !c.Response().Committed {`
	`41`	`+ return errorEncoder(c, err)`
	`42`	`+ }`
	`43`	`+ l.Error("response headers already written", "err", err)`
`41`	`44`	`}`
`42`	`45`	`return nil`
`43`	`46`	`}`