PL-56357 - Fix regex used to generate notifications (#359)

**What**

- Updates the regex's used to extract flag names from redis keys to
  handle underscores

**Why**

- When the Primary restarts it diffs the new and old config and sends
  notifications if there have been any changes. The Regex used to
extract the identifier wasn't handling underscores and was truncating
flag identifiers. This meant it sent notifications with incorrect flag
identifiers to SDKs.

**Testing**

- Added a unit test for the `BuildNotification` method
- Tested manually locally

Author: jcox250

repository/inventory_repo.go

@@ -22,8 +22,8 @@ const (
 )
 
 var (
-	featureConfigRegEx = regexp.MustCompile(`env-([a-zA-Z0-9-]+)-feature-config-([a-zA-Z0-9-]+)`)
-	segmentConfigRegEx = regexp.MustCompile(`env-([a-zA-Z0-9-]+)-segment-([a-zA-Z0-9-]+)`)
+	featureConfigRegEx = regexp.MustCompile(`env-([a-zA-Z0-9-_]+)-feature-config-([a-zA-Z0-9-_]+)`)
+	segmentConfigRegEx = regexp.MustCompile(`env-([a-zA-Z0-9-]+)-segment-([a-zA-Z0-9-_]+)`)
 )
 
 // InventoryRepo is a repository that stores all references to all assets for the key.

repository/inventory_repo_test.go

@@ -211,3 +211,112 @@ func TestInventoryRepo_Cleanup(t *testing.T) {
 		})
 	}
 }
+
+func TestInventoryRepo_BuildNotificatons(t *testing.T) {
+
+	type args struct {
+		assets domain.Assets
+	}
+
+	type expected struct {
+		notifications []domain.SSEMessage
+	}
+
+	testCases := map[string]struct {
+		args     args
+		expected expected
+	}{
+		"Given I have assets with no underscores": {
+			args: args{
+				assets: domain.Assets{
+					Deleted: map[string]string{
+						"env-1234-feature-config-foobar": "",
+					},
+					Created: map[string]string{
+						"env-1234-feature-config-helloworld": "",
+					},
+					Patched: map[string]string{
+						"env-1234-segment-foobar": "",
+					},
+				},
+			},
+			expected: expected{
+				notifications: []domain.SSEMessage{
+					{
+						Event:       "delete",
+						Domain:      "flag",
+						Identifier:  "foobar",
+						Version:     0,
+						Environment: "1234",
+					},
+					{
+						Event:       "create",
+						Domain:      "flag",
+						Identifier:  "helloworld",
+						Version:     0,
+						Environment: "1234",
+					},
+					{
+						Event:       "patch",
+						Domain:      "target-segment",
+						Identifier:  "foobar",
+						Version:     0,
+						Environment: "1234",
+					},
+				},
+			},
+		},
+		"Given I have assets with underscores": {
+			args: args{
+				assets: domain.Assets{
+					Deleted: map[string]string{
+						"env-1234-feature-config-PIE_ENABLE_THIS_THING": "",
+					},
+					Created: map[string]string{
+						"env-1234-feature-config-_CDS__ENABLED___FLAG": "",
+					},
+					Patched: map[string]string{
+						"env-1234-segment-_SOME_SPECIAL_SEGMENT__": "",
+					},
+				},
+			},
+			expected: expected{
+				notifications: []domain.SSEMessage{
+					{
+						Event:       "delete",
+						Domain:      "flag",
+						Identifier:  "PIE_ENABLE_THIS_THING",
+						Version:     0,
+						Environment: "1234",
+					},
+					{
+						Event:       "create",
+						Domain:      "flag",
+						Identifier:  "_CDS__ENABLED___FLAG",
+						Version:     0,
+						Environment: "1234",
+					},
+					{
+						Event:       "patch",
+						Domain:      "target-segment",
+						Identifier:  "_SOME_SPECIAL_SEGMENT__",
+						Version:     0,
+						Environment: "1234",
+					},
+				},
+			},
+		},
+	}
+
+	for desc, tc := range testCases {
+		desc := desc
+		tc := tc
+
+		t.Run(desc, func(t *testing.T) {
+
+			i := InventoryRepo{}
+			actual := i.BuildNotifications(tc.args.assets)
+			assert.Equal(t, tc.expected.notifications, actual)
+		})
+	}
+}