Skip to content

Commit 43a082e

Browse files
Change 'number' to 'int' input on number variations (#93)
1 parent a1a3397 commit 43a082e

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

evaluation/evaluator.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -385,8 +385,8 @@ func (e Evaluator) IntVariation(identifier string, target *Target, defaultValue
385385

386386
// NumberVariation returns number evaluation for target
387387
func (e Evaluator) NumberVariation(identifier string, target *Target, defaultValue float64) float64 {
388-
389-
variation, err := e.evaluate(identifier, target, "number")
388+
//all numbers are stored as ints in the database
389+
variation, err := e.evaluate(identifier, target, "int")
390390
if err != nil {
391391
e.logger.Errorf("Error while evaluating number flag '%s', err: %v", identifier, err)
392392
return defaultValue

evaluation/evaluator_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ var (
136136
Variation: &heavyWeight,
137137
},
138138
Variations: numberVariations,
139-
Kind: "number",
139+
Kind: "int",
140140
},
141141
org: {
142142
Feature: org,
@@ -173,7 +173,7 @@ var (
173173
Value: invalidNumberValue,
174174
},
175175
},
176-
Kind: "number",
176+
Kind: "int",
177177
},
178178
invalidJSON: {
179179
Feature: invalidJSON,

0 commit comments

Comments
 (0)