diff --git a/lib/PuppeteerSharp.Nunit/PuppeteerTestAttribute.cs b/lib/PuppeteerSharp.Nunit/PuppeteerTestAttribute.cs index c8bc6d49c..1b51a2a20 100644 --- a/lib/PuppeteerSharp.Nunit/PuppeteerTestAttribute.cs +++ b/lib/PuppeteerSharp.Nunit/PuppeteerTestAttribute.cs @@ -22,8 +22,8 @@ public class PuppeteerTestAttribute : NUnitAttribute, IApplyToTest private static TestExpectation[] _localExpectations; private static TestExpectation[] _upstreamExpectations; - public static readonly bool IsChrome = Environment.GetEnvironmentVariable("BROWSER") != "FIREFOX"; - public static readonly bool IsCdp = string.IsNullOrEmpty(Environment.GetEnvironmentVariable("PROTOCOL")) || Environment.GetEnvironmentVariable("PROTOCOL")!.Equals("cdp"); + public static readonly bool IsChrome = false; + public static readonly bool IsCdp = false; public static readonly HeadlessMode Headless = string.IsNullOrEmpty(Environment.GetEnvironmentVariable("HEADLESS_MODE")) ? diff --git a/lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json b/lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json index d7b329a12..1480be245 100644 --- a/lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json +++ b/lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json @@ -1515,21 +1515,6 @@ "FAIL" ] }, - { - "comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one", - "testIdPattern": "[page.spec] *Page.setContent*", - "platforms": [ - "darwin", - "linux", - "win32" - ], - "parameters": [ - "webDriverBiDi" - ], - "expectations": [ - "FAIL" - ] - }, { "comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one", "testIdPattern": "[proxy.spec] *", diff --git a/lib/PuppeteerSharp.Tests/PageTests/SetContentTests.cs b/lib/PuppeteerSharp.Tests/PageTests/SetContentTests.cs index 8675a3214..8d83daffc 100644 --- a/lib/PuppeteerSharp.Tests/PageTests/SetContentTests.cs +++ b/lib/PuppeteerSharp.Tests/PageTests/SetContentTests.cs @@ -7,7 +7,7 @@ namespace PuppeteerSharp.Tests.PageTests { public class SetContentTests : PuppeteerPageBaseTest { - const string ExpectedOutput = "
hello
"; + private const string ExpectedOutput = "
hello
"; public async Task Usage(IBrowser browser) { @@ -65,7 +65,7 @@ public async Task ShouldRespectTimeout() Timeout = 1 })); - Assert.That(exception.Message, Does.Contain("Timeout of 1 ms exceeded")); + Assert.That(exception!.Message, Does.Contain("Timeout of 1 ms exceeded")); } [Test, Retry(2), PuppeteerTest("page.spec", "Page Page.setContent", "should respect default navigation timeout")] @@ -79,7 +79,7 @@ public async Task ShouldRespectDefaultTimeout() var exception = Assert.ThrowsAsync(async () => await Page.SetContentAsync($"")); - Assert.That(exception.Message, Does.Contain("Timeout of 1 ms exceeded")); + Assert.That(exception!.Message, Does.Contain("Timeout of 1 ms exceeded")); } [Test, Retry(2), PuppeteerTest("page.spec", "Page Page.setContent", "should await resources to load")] diff --git a/lib/PuppeteerSharp/Bidi/BidiElementHandle.cs b/lib/PuppeteerSharp/Bidi/BidiElementHandle.cs index b3fb070ac..a5e077577 100644 --- a/lib/PuppeteerSharp/Bidi/BidiElementHandle.cs +++ b/lib/PuppeteerSharp/Bidi/BidiElementHandle.cs @@ -47,8 +47,6 @@ public static IJSHandle From(RemoteValue value, BidiRealm realm) return new BidiElementHandle(value, realm); } - public override ValueTask DisposeAsync() => throw new System.NotImplementedException(); - public override Task UploadFileAsync(bool resolveFilePaths, params string[] filePaths) => throw new System.NotImplementedException(); public override Task