From c266068f080b8d76b2d363f3fc52ba4283bde41b Mon Sep 17 00:00:00 2001 From: Pedro Henrique Windisch Date: Thu, 20 Jun 2024 17:40:38 -0300 Subject: [PATCH] fix: remove --disable-field-trial-config --- .../TestExpectations/TestExpectations.upstream.json | 13 +++++++++++++ lib/PuppeteerSharp/ChromeLauncher.cs | 3 +-- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.upstream.json b/lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.upstream.json index 5336670a4..fb4d312b0 100644 --- a/lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.upstream.json +++ b/lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.upstream.json @@ -313,6 +313,13 @@ "expectations": ["SKIP"], "comment": "The test relies on the default page partition key do not contain the source origin. This is not the case for Firefox." }, + { + "testIdPattern": "[cookies.spec] Cookie specs Page.setCookie should set secure same-site cookies from a frame", + "platforms": ["darwin", "linux", "win32"], + "parameters": ["chrome"], + "expectations": ["FAIL"], + "comment": "Failes with fieldtrial testing config in Chrome" + }, { "testIdPattern": "[coverage.spec] *", "platforms": ["darwin", "linux", "win32"], @@ -1313,6 +1320,12 @@ "expectations": ["FAIL"], "comment": "TODO: add a comment explaining why this expectation is required (include links to issues)" }, + { + "testIdPattern": "[cookies.spec] Cookie specs Page.setCookie should set secure same-site cookies from a frame", + "platforms": ["darwin", "linux", "win32"], + "parameters": ["chrome", "chrome-headless-shell"], + "expectations": ["PASS"] + }, { "testIdPattern": "[cookies.spec] Cookie specs Page.setCookie should set secure same-site cookies from a frame", "platforms": ["darwin", "linux", "win32"], diff --git a/lib/PuppeteerSharp/ChromeLauncher.cs b/lib/PuppeteerSharp/ChromeLauncher.cs index 0ccfe6049..2f4951375 100644 --- a/lib/PuppeteerSharp/ChromeLauncher.cs +++ b/lib/PuppeteerSharp/ChromeLauncher.cs @@ -63,7 +63,7 @@ internal static string[] GetDefaultArgs(LaunchOptions options) var chromiumArguments = new List( [ - "--allow-pre-commit-input", + "--allow-pre-commit-input", "--disable-background-networking", "--disable-background-timer-throttling", "--disable-backgrounding-occluded-windows", @@ -74,7 +74,6 @@ internal static string[] GetDefaultArgs(LaunchOptions options) "--disable-default-apps", "--disable-dev-shm-usage", "--disable-extensions", - "--disable-field-trial-config", "--disable-hang-monitor", "--disable-infobars", "--disable-ipc-flooding-protection",