Skip to content

Conversation

@wuarmin
Copy link
Contributor

@wuarmin wuarmin commented Jun 3, 2025

@timriley
Copy link
Member

timriley commented Jun 3, 2025

This looks great, @wuarmin! Thanks for doing it!

Could you please add one test to demonstrate this working? Your exact example from your forum post would be great.

@wuarmin
Copy link
Contributor Author

wuarmin commented Jun 3, 2025

Thanks for reviewing.
Yes, I'll see if I can find the time today.
Have a nice evening.

@wuarmin
Copy link
Contributor Author

wuarmin commented Jun 3, 2025

I added a test.

@wuarmin
Copy link
Contributor Author

wuarmin commented Sep 29, 2025

@timriley,
perhaps you no longer have this important fix on your radar. I just wanted to remind you, as file upload is currently being discussed. It might save you some time.

@timriley
Copy link
Member

Thanks @wuarmin, my radar gets a bit flaky sometimes. 😅 I really appreciate the nudge!

@timriley
Copy link
Member

timriley commented Oct 1, 2025

Thanks @wuarmin for this fix!

@timriley timriley merged commit 1184595 into hanami:main Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants