Marshal with nested structs

[theseeker58]

Hello there
I'm trying to get acquainted with golang in general and hamba/avro in particular. I have written a demo project to marshal a struct tagged with avro and everything works fine

type Employee struct {
	ID        string  `json:"id" avro:"id"`
	Firstname string  `json:"firstname" binding:"alpha" avro:"firstname"`
	Surname   string  `json:"surname" avro:"surname"`
	Salary    float64 `json:"salary,omitempty" binding:"gte=1000" avro:"salary"`
}

	schema, err := avro.ParseFiles("resources/employee_avro_schema.avsc")
	if err != nil {
		log.Fatal(err)
	}
	jsonBuff, err := os.ReadFile("resources/employee.json")
	if err != nil {
		log.Fatal(err)
	}
	var emp = new(Employee)
	error := json.Unmarshal(jsonBuff, &emp)
	if err != nil {
		log.Fatal(error)
	}
	log.Println("json:", *emp)
	avroBuff, ex := avro.Marshal(schema, emp)
	if ex != nil {
		log.Fatal(ex)
	}
	var unmarshaledEmp = new(Employee)
	if err := avro.Unmarshal(schema, avroBuff, &unmarshaledEmp); err != nil {
		log.Fatal(err)
	}

	log.Println("unmarshaled emp:", *unmarshaledEmp)
	if *emp == *unmarshaledEmp {
		log.Println("equal")
	} else {
		log.Println("different")
	}

The schema

{
  "name": "Employee",
  "namespace": "com.fsajeva.avro",
  "type": "record",
  "fields": [
    {
      "name": "id",
      "type": "string"
    },
    {
      "name": "firstname",
      "type": "string"
    },
    {
      "name": "surname",
      "type": "string"
    },
    {
      "name": "salary",
      "type": "double"
    }
  ]
}

And finally the json file

{
  "id": "1",
  "firstname": "John",
  "surname": "Dow",
  "salary": 1000.99
}

But when I try to create a more complex example nesting a struct named Address I get this error
avro: unable to resolve type *main.Employee

This is the new schema

[
{
  "name": "Address",
  "namespace": "com.fsajeva.avro",
  "type": "record",
  "fields": [
    {
      "name": "street",
      "type": "string"
    },
    {
      "name": "zipCode",
      "type": "string"
    },
    {
      "name": "city",
      "type": "string"
    },
    {
      "name": "country",
      "type": "string"
    }
  ]
},
{
  "name": "Employee",
  "namespace": "com.fsajeva.avro",
  "type": "record",
  "fields": [
    {
      "name": "id",
      "type": "string"
    },
    {
      "name": "firstname",
      "type": "string"
    },
    {
      "name": "surname",
      "type": "string"
    },
    {
      "name": "salary",
      "type": "double"
    },
    {
      "name": "address",
      "type": "com.fsajeva.avro.Address"
    }
  ]
}
]

And this the new structs definition

type Address struct {
	Street  string `json:"street,omitempty" avro:"street"`
	ZipCode string `json:"zipCode,omitempty" avro:"zipCode"`
	City    string `json:"city,omitempty" avro:"city"`
	Country string `json:"country,omitempty" avro:"country"`
}

type Employee struct {
	ID        string  `json:"id" avro:"id"`
	Firstname string  `json:"firstname" binding:"alpha" avro:"firstname"`
	Surname   string  `json:"surname" avro:"surname"`
	Salary    float64 `json:"salary,omitempty" binding:"gte=1000" avro:"salary"`
	Address   Address `json:"address,omitempty" avro:"address"`
}

And finally the new json file

{
  "id": "1",
  "firstname": "John",
  "surname": "Dow",
  "salary": 1000.99,
  "address":
    {
        "street": "Via dei Mille, 41",
        "zipCode": "00136",
        "city": "Rome",
        "country": "Italy"
    }
}

Am I missing anything? Any help?
Thank you all

[nrwiersma]

Your schema is incorrect, it should be something like:

{
  "name": "Employee",
  "namespace": "com.fsajeva.avro",
  "type": "record",
  "fields": [
    {
      "name": "id",
      "type": "string"
    },
    {
      "name": "firstname",
      "type": "string"
    },
    {
      "name": "surname",
      "type": "string"
    },
    {
      "name": "salary",
      "type": "double"
    },
    {
      "name": "address",
      "type": {
  "name": "Address",
  "namespace": "com.fsajeva.avro",
  "type": "record",
  "fields": [
    {
      "name": "street",
      "type": "string"
    },
    {
      "name": "zipCode",
      "type": "string"
    },
    {
      "name": "city",
      "type": "string"
    },
    {
      "name": "country",
      "type": "string"
    }
  ]
}
    }
  ]
}

The schema you have is a top level union, and the decoder is looking for a registered decoder.

[theseeker58]

Got it! I have corrected the schema and it works perfectly!
Thank you