Fix setStartDate_ underscore character

[twistedpair]

Curious why the HasStartDate and HasEndDate interfaces were implemented with an _ (underscore) character in the names to differentiate the String setter from the Date setter method.

Since we're in Java, can we just overload this method rather than using names that don't conform with Java method naming standards?

Just curious since I'll gladly send in the correctling Pull Request, but wanted to ensure this was not for some JSO Overlay kung fu. In that case, I'd suggest setStartDateFromString. Thanks.

public interface HasStartDate {

    /**
     * Set the min date in the component.
     * @param date: the date format when the calendar will start
     */
    void setStartDate(String date);

    /**
     * Set the min date in the component.
     * @param date: the date format when the calendar will start
     */
    void setStartDate_(Date date);


}

[caarlos0]

If I'm not wrong, this is related to set the properties in xml files...

[twistedpair]

@caarlos0

So you're saying this is due to a lack of virtual method usage in UiBinder so that you can use the following?

<b:DateBox startDate="22-10-2012" format="dd-mm-yyyy" />

GWT exposes all public setters on Widgets that it can easily marshal types for. In my experience this includes primitives and wrappers including int, double, long, and boolean. It also handles String and enum. However, types beyond this are ignored (my list is not exhaustive).

For example, from DateBox, only setStartView(String mode) is exposed to UiBinder. Accordingly, the setters with Date argments are not exposed for DateBox and thus, using the overloaded virtual method for Date and String types should not cause a problem because only one of them is being exposed via UiBinder, hence there is no overloading at the point of UiBinder.

    /**
     * {@inheritDoc}
     */
    @Override
    public void setStartView(ViewMode mode) {
        setStartView(mode.name());
    }

    /**
     * {@inheritDoc}
     */
    @Override
    public void setStartView(String mode) {
        getElement().setAttribute("data-date-start-view", mode.toLowerCase());
    }

[caarlos0]

Interesting... didn't know about that..

@soundTricker, what do you think about that?

[soundTricker]

Um..
I guess , that is no problem, if modify that method.

On the contrary.
I think, nor is it enough to fix.