Let GWT handle style names.

[dominikmayer]

I'm not sure we want this but I think we should talk about it:

Right now we add Strings of all the bootstrap style names to the Widgets. There will be conflicts if the user has a similarly named style. The solution would be to let GWT handle the style names and refer to them via CSSResource (https://developers.google.com/web-toolkit/doc/latest/DevGuideClientBundle). I think we would have to deactivate obfuscation because bootstrap.js probably relies on the correct names.

In this case it should also be easier to deal with changes in bootstrap because we would probably get compile time errors if a referenced style is not in the css file.

What do you think?

[soundTricker]

Ummm......
I think keep the idea as is.

Because,
I think same thinks when developing bootstrap4gwt.
but Give up it.
Because when I create CssBundle Inteface by CssBundle Generator,
Generator is throw error that can not parse it.
if we create CssBundle,we should modify bootstrap.css many things.
Maybe we will do that, high cost but little advantage.

[dominikmayer]

I'm leaning towards finding a way to use CSSRessource. People working with GWT expect a certain behavior. We can't expect every user to have deeper insight into inner workings of GWT and gwt-bootstrap. Those "newbie" users might get frustrated if things don't work as expected and they have no idea why.

[dominikmayer]

This seems to be difficult. GWT doesn't support CSS3 yet so we can't use a CssResource. The error message is: invalid pseudo function name nth-child.

[caarlos0]

Yeap, its because that error that I didn't use CssResource :P

[dominikmayer]

Yeah. Once I saw the error I was sure that you had tried the same :-D.

[caarlos0]

close this until new GWT version?

[soundTricker]

👍 with @caarlos0

[dominikmayer]

I put it in the Backlog, I think it can stay there so we won't forget it. I'll add a new label "waiting".

[tomfisher]

I tried to generate a bundle file from the original css, it did fail. However, there was just one style with the nth-child selector causing that:

.table-striped tbody tr:nth-child(odd) td,
.table-striped tbody tr:nth-child(odd) th {
background-color: #f9f9f9;
}

We could resolve it by dynamically generating the above css code when injecting the style bundle into the document. For example,

private void fixStyle {
            String id = "a random id that will be removed after injection";
    Element e = Document.get().getElementById(id);
    if (e == null) {
        e = Document.get().createStyleElement();
        e.setId(id);
    }
           String table-striped = "the text composed by code";
            e.setInnerText(table-striped);

}

What do you guys think?