Duplicate partial inclusion in head.html and head-end.html

[chalin]

@aidanranney: this is a Docsy migration followup question concerning these issues:

• HTML head meta elements are duplicated HTML head meta elements are duplicated #745
• Homepage has empty title/name for opengraph, twitter, and itemprop Homepage has empty title/name for opengraph, twitter, and itemprop #744

Investigating this a bit I noticed the following:

(1) https://github.com/grpc/grpc.io/blob/main/layouts/partials/hooks/head-end.html contains:

{{ partial "google-analytics.html" . }}
{{ partial "meta.html" . }}
{{ partial "favicons.html" . }}

(2) But https://github.com/grpc/grpc.io-docsy/blob/e95da39c9933afe159b74b0d6b5b71407aab7d7d/layouts/partials/head.html:

• Also contains
  • <meta> tags
  • A partial for favicons
  • A partial for Google analytics
• As well as an include of head-end.html at the end of the file.

I'm sure that the duplication wasn't intentional, but what was the original intent? Was head-end.html created by mistake, or was the intent to customize head.html (by removing the elements that were being added to head-end.html)?

/cc @nate-double-u @celestehorgan

[aidanranney]

👋 @chalin - I believe head-end.html was created purposefully to give an entry point documented in the code for extending head.html. I've lost the full context on the inclusion of those partials in that file, though at one point we were customizing the head.html partial, which went through iterations. These lines appear to be either missed in cleanup or a rebase.

[celestehorgan]

@chalin – I agree that this wasn't intentional. Removing the duplicated partials will 100% fix this.