From 2f090c62a66e36c756350e9a942f965dca1ae276 Mon Sep 17 00:00:00 2001 From: Mattias Wiberg Date: Fri, 24 Oct 2025 16:06:54 +0200 Subject: [PATCH 1/2] grpc-js: Fix server keep alive timeout not properly destroying connections --- packages/grpc-js/src/server.ts | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/grpc-js/src/server.ts b/packages/grpc-js/src/server.ts index 6e68c695a..73d84b787 100644 --- a/packages/grpc-js/src/server.ts +++ b/packages/grpc-js/src/server.ts @@ -1609,7 +1609,7 @@ export class Server { if (err) { this.keepaliveTrace('Ping failed with error: ' + err.message); sessionClosedByServer = true; - session.close(); + session.destroy(); } else { this.keepaliveTrace('Received ping response'); maybeStartKeepalivePingTimer(); @@ -1631,7 +1631,7 @@ export class Server { 'Connection dropped due to ping send error: ' + pingSendError ); sessionClosedByServer = true; - session.close(); + session.destroy(); return; } @@ -1640,7 +1640,7 @@ export class Server { this.keepaliveTrace('Ping timeout passed without response'); this.trace('Connection dropped by keepalive timeout'); sessionClosedByServer = true; - session.close(); + session.destroy(); }, this.keepaliveTimeoutMs); keepaliveTimer.unref?.(); }; @@ -1803,7 +1803,7 @@ export class Server { duration ); sessionClosedByServer = true; - session.close(); + session.destroy(); } else { this.keepaliveTrace('Received ping response'); maybeStartKeepalivePingTimer(); @@ -1826,7 +1826,7 @@ export class Server { 'Connection dropped due to ping send error: ' + pingSendError ); sessionClosedByServer = true; - session.close(); + session.destroy(); return; } @@ -1840,7 +1840,7 @@ export class Server { 'Connection dropped by keepalive timeout from ' + clientAddress ); sessionClosedByServer = true; - session.close(); + session.destroy(); }, this.keepaliveTimeoutMs); keepaliveTimeout.unref?.(); }; From 235474ef4ad8e6a5ab678001d461e83c4518fe06 Mon Sep 17 00:00:00 2001 From: Michael Lumish Date: Mon, 1 Dec 2025 12:03:35 -0500 Subject: [PATCH 2/2] grpc-js: Bump to 1.14.2 --- packages/grpc-js/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/grpc-js/package.json b/packages/grpc-js/package.json index f5f717089..b157dc37c 100644 --- a/packages/grpc-js/package.json +++ b/packages/grpc-js/package.json @@ -1,6 +1,6 @@ { "name": "@grpc/grpc-js", - "version": "1.14.1", + "version": "1.14.2", "description": "gRPC Library for Node - pure JS implementation", "homepage": "https://grpc.io/", "repository": "https://github.com/grpc/grpc-node/tree/master/packages/grpc-js",