cleanup specify groups spec (#1006)

Author: grosser

spec/parallel_tests/grouper_spec.rb

@@ -76,116 +76,49 @@ def call(num_groups, options = {})
       )
     end
 
-    context 'with specific groups provided directly' do
-      it "groups specify_groups as specified when specify_groups is just one spec" do
+    context 'specify_groups' do
+      it "groups with one spec" do
         expect(call(3, specify_groups: '1')).to eq([["1"], ["2", "5"], ["3", "4"]])
       end
 
-      it "groups specify_groups as specified when specify_groups is just multiple specs in one process" do
+      it "groups with multiple specs in one process" do
         expect(call(3, specify_groups: '3,1')).to eq([["3", "1"], ["5"], ["2", "4"]])
       end
 
-      it "groups specify_groups as specified when specify_groups is multiple specs" do
+      it "groups with multiple specs and multiple processes" do
         expect(call(3, specify_groups: '1,2|4')).to eq([["1", "2"], ["4"], ["3", "5"]])
       end
 
-      it "specify_groups aborts when number of specs separated by pipe is out of bounds" do
+      it "aborts when number of specs is higher than number of processes" do
         expect do
           call(3, specify_groups: '1|2|3|4')
         end.to raise_error(
           "Number of processes separated by pipe must be less than or equal to the total number of processes"
         )
       end
 
-      it "specify_groups aborts when spec passed in doesn't match existing specs" do
+      it "aborts when spec passed in doesn't match existing specs" do
         expect do
           call(3, specify_groups: '1|2|6')
         end.to raise_error(
           "Could not find [\"6\"] from --specify-groups in the selected files & folders"
         )
       end
 
-      it "specify_groups aborts when spec passed in doesn't match existing specs again" do
-        expect do
-          call(3, specify_groups: '1,6|2')
-        end.to raise_error(
-          "Could not find [\"6\"] from --specify-groups in the selected files & folders"
-        )
-      end
-
-      it "specify_groups aborts when number of specs is equal to number passed in" do
+      it "aborts when number of specs is equal to number of processes and not all specs are used" do
         expect do
           call(3, specify_groups: '1|2|3')
         end.to raise_error(/The specs that aren't run:\n\["4", "5"\]/)
       end
 
-      it "specify_groups does not abort when the every single spec is specified in it" do
+      it "does not abort when the every single spec is specified" do
         expect(call(3, specify_groups: '1,2|3,4|5')).to eq([["1", "2"], ["3", "4"], ["5"]])
       end
-    end
-
-    context 'with specific groups provided through STDIN' do
-      it "groups specify_groups as specified when specify_groups is just one spec" do
-        allow($stdin).to receive(:read).and_return("1\n")
 
-        expect(call(3, specify_groups: '-')).to eq([["1"], ["2", "5"], ["3", "4"]])
-      end
-
-      it "groups specify_groups as specified when specify_groups is just multiple specs in one process" do
+      it "can read from stdin" do
         allow($stdin).to receive(:read).and_return("3,1\n")
-
         expect(call(3, specify_groups: '-')).to eq([["3", "1"], ["5"], ["2", "4"]])
       end
-
-      it "groups specify_groups as specified when specify_groups is multiple specs" do
-        allow($stdin).to receive(:read).and_return("1,2|4\n")
-
-        expect(call(3, specify_groups: '-')).to eq([["1", "2"], ["4"], ["3", "5"]])
-      end
-
-      it "specify_groups aborts when number of specs separated by pipe is out of bounds" do
-        allow($stdin).to receive(:read).and_return("1|2|3|4\n")
-
-        expect do
-          call(3, specify_groups: '-')
-        end.to raise_error(
-          "Number of processes separated by pipe must be less than or equal to the total number of processes"
-        )
-      end
-
-      it "specify_groups aborts when spec passed in doesn't match existing specs" do
-        allow($stdin).to receive(:read).and_return("1|2|6\n")
-
-        expect do
-          call(3, specify_groups: '-')
-        end.to raise_error(
-          "Could not find [\"6\"] from --specify-groups in the selected files & folders"
-        )
-      end
-
-      it "specify_groups aborts when spec passed in doesn't match existing specs again" do
-        allow($stdin).to receive(:read).and_return("1,6|2\n")
-
-        expect do
-          call(3, specify_groups: '-')
-        end.to raise_error(
-          "Could not find [\"6\"] from --specify-groups in the selected files & folders"
-        )
-      end
-
-      it "specify_groups aborts when number of specs is equal to number passed in" do
-        allow($stdin).to receive(:read).and_return("1|2|3\n")
-
-        expect do
-          call(3, specify_groups: '-')
-        end.to raise_error(/The specs that aren't run:\n\["4", "5"\]/)
-      end
-
-      it "specify_groups does not abort when the every single spec is specified in it" do
-        allow($stdin).to receive(:read).and_return("1,2|3,4|5\n")
-
-        expect(call(3, specify_groups: '-')).to eq([["1", "2"], ["3", "4"], ["5"]])
-      end
     end
   end