Fix logs extra fetches when switching nodes

Signed-off-by: Ayoub LABIDI <[email protected]>

Author: ayolab

src/components/report-viewer-tab.jsx

@@ -20,8 +20,6 @@ import { ReportType } from 'utils/report/report.type';
 import { sortSeverityList } from 'utils/report/report-severity';
 import FormControlLabel from '@mui/material/FormControlLabel';
 import { Box, Switch } from '@mui/material';
-import { NotificationsUrlKeys, useNotificationsListener } from '@gridsuite/commons-ui';
-import { isStudyNotification } from '../types/notification-types';
 
 const styles = {
     div: {
@@ -48,7 +46,6 @@ export const ReportViewerTab = ({ visible, currentNode, disabled }) => {
     const [nodeOnlyReport, setNodeOnlyReport] = useState(true);
     const [resetFilters, setResetFilters] = useState(false);
     const treeModel = useSelector((state) => state.networkModificationTreeModel);
-    const currentRootNetworkUuid = useSelector((state) => state.currentRootNetworkUuid);
     const intl = useIntl();
     const [isReportLoading, fetchReport, fetchReportSeverities] = useReportFetcher(
         COMPUTING_AND_NETWORK_MODIFICATION_TYPE.NETWORK_MODIFICATION
@@ -70,48 +67,24 @@ export const ReportViewerTab = ({ visible, currentNode, disabled }) => {
         return rootNode?.id;
     }, [treeModel]);
 
-    const fetchReportAndSeverities = useCallback(() => {
-        fetchReport(nodeOnlyReport).then((r) => {
-            if (r !== undefined) {
-                setReport(r);
-                fetchReportSeverities(r.id, r.parentId ? ReportType.NODE : ReportType.GLOBAL).then((severities) => {
-                    setSeverities(sortSeverityList(severities));
-                });
-            }
-        });
-    }, [fetchReport, nodeOnlyReport, fetchReportSeverities]);
-
-    // Listen for STUDY notifications
-    const handleNotification = useCallback(
-        (event) => {
-            const eventData = JSON.parse(event.data);
-            if (
-                visible &&
-                !disabled &&
-                isStudyNotification(eventData) &&
-                eventData.headers.rootNetworkUuid === currentRootNetworkUuid &&
-                eventData.headers.node === currentNode?.id
-            ) {
-                fetchReportAndSeverities();
-            }
-        },
-        [visible, disabled, currentRootNetworkUuid, currentNode?.id, fetchReportAndSeverities]
-    );
-
-    useNotificationsListener(NotificationsUrlKeys.STUDY, { listenerCallbackMessage: handleNotification });
-
-    // This useEffect is responsible for updating the reports when the user opens the LOGS panel
     useEffect(() => {
-        // Visible and !disabled ensure that the user has the LOGS tab open and the current node is built.
+        // Visible and !disabled ensure that the current node is built.
         if (visible && !disabled) {
-            fetchReportAndSeverities();
+            fetchReport(nodeOnlyReport).then((r) => {
+                if (r !== undefined) {
+                    setReport(r);
+                    fetchReportSeverities(r.id, r.parentId ? ReportType.NODE : ReportType.GLOBAL).then((severities) => {
+                        setSeverities(sortSeverityList(severities));
+                    });
+                }
+            });
         } else {
             // if the user unbuilds a node, the report needs to be reset.
             // otherwise, the report will be kept in the state and useless report fetches with previous id will be made when the user rebuilds the node.
             setReport();
             setSeverities();
         }
-    }, [visible, currentNode?.id, disabled, nodeOnlyReport, fetchReportAndSeverities]);
+    }, [visible, currentNode, disabled, fetchReport, nodeOnlyReport, fetchReportSeverities]);
 
     return (
         <>