Skip to content

Commit 11f4a73

Browse files
authored
Merge branch 'main' into add-version-in-logs
2 parents 0919141 + 503d5a1 commit 11f4a73

26 files changed

+1369
-85
lines changed

pom.xml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919

2020
<groupId>org.gridsuite</groupId>
2121
<artifactId>gridsuite-filter</artifactId>
22-
<version>1.11.0-SNAPSHOT</version>
22+
<version>1.13.0-SNAPSHOT</version>
2323

2424
<packaging>jar</packaging>
2525
<name>Filter library</name>
@@ -149,6 +149,11 @@
149149
<artifactId>hamcrest</artifactId>
150150
<scope>test</scope>
151151
</dependency>
152+
<dependency>
153+
<groupId>org.assertj</groupId>
154+
<artifactId>assertj-core</artifactId>
155+
<scope>test</scope>
156+
</dependency>
152157
<dependency>
153158
<groupId>com.powsybl</groupId>
154159
<artifactId>powsybl-iidm-test</artifactId>

src/main/java/org/gridsuite/filter/AbstractFilter.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,9 @@
88

99
import com.fasterxml.jackson.annotation.JsonSubTypes;
1010
import com.fasterxml.jackson.annotation.JsonTypeInfo;
11-
import lombok.*;
11+
import lombok.AllArgsConstructor;
12+
import lombok.Data;
13+
import lombok.NoArgsConstructor;
1214
import lombok.experimental.SuperBuilder;
1315
import org.gridsuite.filter.expertfilter.ExpertFilter;
1416
import org.gridsuite.filter.identifierlistfilter.FilterEquipments;
@@ -43,7 +45,7 @@ public abstract class AbstractFilter implements IFilterAttributes {
4345

4446
private UUID id;
4547

46-
private Date modificationDate;
48+
private Date modificationDate; // TODO use Instant like in servers (client not on same timezone than server)
4749

4850
private EquipmentType equipmentType;
4951

src/main/java/org/gridsuite/filter/IFilterAttributes.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,16 @@
1010
import org.gridsuite.filter.utils.EquipmentType;
1111
import org.gridsuite.filter.utils.FilterType;
1212

13+
import java.util.Date;
14+
import java.util.UUID;
15+
1316
/**
1417
* @author Jacques Borsenberger <jacques.borsenberger at rte-france.com>
1518
*/
1619
public interface IFilterAttributes {
17-
java.util.UUID getId();
20+
UUID getId();
1821

19-
java.util.Date getModificationDate();
22+
Date getModificationDate(); // TODO use Instant like in servers (client not on same timezone than server)
2023

2124
FilterType getType();
2225

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
package org.gridsuite.filter.exception;
2+
3+
import lombok.experimental.StandardException;
4+
5+
@StandardException
6+
public class InvalidEquipmentType extends RuntimeException {
7+
}
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
package org.gridsuite.filter.exception;
2+
3+
import lombok.experimental.StandardException;
4+
5+
@StandardException
6+
public class UnknownFilterType extends RuntimeException {
7+
}

src/main/java/org/gridsuite/filter/expertfilter/ExpertFilter.java

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,7 @@
88

99
import com.fasterxml.jackson.annotation.JsonProperty;
1010
import com.powsybl.iidm.network.TopologyKind;
11-
import lombok.EqualsAndHashCode;
12-
import lombok.Getter;
13-
import lombok.NoArgsConstructor;
14-
import lombok.Setter;
11+
import lombok.*;
1512
import lombok.experimental.SuperBuilder;
1613
import org.gridsuite.filter.AbstractFilter;
1714
import org.gridsuite.filter.expertfilter.expertrule.AbstractExpertRule;
@@ -24,11 +21,11 @@
2421
/**
2522
* @author Antoine Bouhours <antoine.bouhours at rte-france.com>
2623
*/
27-
@Getter
28-
@Setter
2924
@SuperBuilder
3025
@NoArgsConstructor
26+
@Data
3127
@EqualsAndHashCode(callSuper = true)
28+
@ToString(callSuper = true)
3229
public class ExpertFilter extends AbstractFilter {
3330

3431
private AbstractExpertRule rules;

src/main/java/org/gridsuite/filter/expertfilter/expertrule/AbstractExpertRule.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,8 @@
1212
import com.fasterxml.jackson.annotation.JsonTypeInfo;
1313
import com.powsybl.iidm.network.Identifiable;
1414
import lombok.AllArgsConstructor;
15-
import lombok.Getter;
15+
import lombok.Data;
1616
import lombok.NoArgsConstructor;
17-
import lombok.Setter;
1817
import lombok.experimental.SuperBuilder;
1918
import org.gridsuite.filter.FilterLoader;
2019
import org.gridsuite.filter.identifierlistfilter.FilterEquipments;
@@ -46,8 +45,7 @@
4645
@JsonInclude(JsonInclude.Include.NON_NULL)
4746
@NoArgsConstructor
4847
@AllArgsConstructor
49-
@Getter
50-
@Setter
48+
@Data
5149
@SuperBuilder
5250
public abstract class AbstractExpertRule {
5351

src/main/java/org/gridsuite/filter/expertfilter/expertrule/BooleanExpertRule.java

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,7 @@
99
import com.fasterxml.jackson.annotation.JsonProperty;
1010
import com.powsybl.commons.PowsyblException;
1111
import com.powsybl.iidm.network.Identifiable;
12-
import lombok.AllArgsConstructor;
13-
import lombok.Getter;
14-
import lombok.NoArgsConstructor;
15-
import lombok.Setter;
12+
import lombok.*;
1613
import lombok.experimental.SuperBuilder;
1714
import org.gridsuite.filter.FilterLoader;
1815
import org.gridsuite.filter.identifierlistfilter.FilterEquipments;
@@ -30,8 +27,9 @@
3027
*/
3128
@AllArgsConstructor
3229
@NoArgsConstructor
33-
@Getter
34-
@Setter
30+
@Data
31+
@EqualsAndHashCode(callSuper = true)
32+
@ToString(callSuper = true)
3533
@SuperBuilder
3634
public class BooleanExpertRule extends AbstractExpertRule {
3735
private Boolean value;

src/main/java/org/gridsuite/filter/expertfilter/expertrule/CombinatorExpertRule.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,10 @@
99
import com.fasterxml.jackson.annotation.JsonProperty;
1010
import com.powsybl.commons.PowsyblException;
1111
import com.powsybl.iidm.network.Identifiable;
12+
import lombok.Data;
13+
import lombok.EqualsAndHashCode;
1214
import lombok.NoArgsConstructor;
15+
import lombok.ToString;
1316
import lombok.experimental.SuperBuilder;
1417
import org.gridsuite.filter.FilterLoader;
1518
import org.gridsuite.filter.identifierlistfilter.FilterEquipments;
@@ -23,6 +26,9 @@
2326
* @author Antoine Bouhours <antoine.bouhours at rte-france.com>
2427
*/
2528
@NoArgsConstructor
29+
@Data
30+
@EqualsAndHashCode(callSuper = true)
31+
@ToString(callSuper = true)
2632
@SuperBuilder
2733
public class CombinatorExpertRule extends AbstractExpertRule {
2834
@Override

src/main/java/org/gridsuite/filter/expertfilter/expertrule/EnumExpertRule.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,10 @@
99
import com.fasterxml.jackson.annotation.JsonProperty;
1010
import com.powsybl.commons.PowsyblException;
1111
import com.powsybl.iidm.network.Identifiable;
12+
import lombok.Data;
13+
import lombok.EqualsAndHashCode;
1214
import lombok.NoArgsConstructor;
15+
import lombok.ToString;
1316
import lombok.experimental.SuperBuilder;
1417
import org.gridsuite.filter.FilterLoader;
1518
import org.gridsuite.filter.identifierlistfilter.FilterEquipments;
@@ -24,6 +27,9 @@
2427
* @author Antoine Bouhours <antoine.bouhours at rte-france.com>
2528
*/
2629
@NoArgsConstructor
30+
@Data
31+
@EqualsAndHashCode(callSuper = true)
32+
@ToString(callSuper = true)
2733
@SuperBuilder
2834
public class EnumExpertRule extends StringExpertRule {
2935
@Override

0 commit comments

Comments
 (0)