Skip to content
This repository was archived by the owner on Dec 19, 2023. It is now read-only.

Commit 9f35684

Browse files
committed
chore: clean up some sonar smells
1 parent 9bb473d commit 9f35684

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

graphql-kickstart-spring-support/src/main/java/graphql/kickstart/spring/AbstractGraphQLController.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public Object graphqlPOST(
4949
try {
5050
request = objectMapper.readGraphQLRequest(body);
5151
} catch (IOException e) {
52-
return handleBodyParsingException(e, serverWebExchange);
52+
return handleBodyParsingException(e);
5353
}
5454
if (request.getQuery() == null) {
5555
request.setQuery("");
@@ -106,8 +106,7 @@ protected abstract Object executeRequest(
106106
Map<String, Object> variables,
107107
ServerWebExchange serverWebExchange);
108108

109-
protected Object handleBodyParsingException(
110-
Exception exception, ServerWebExchange serverWebExchange) {
109+
protected Object handleBodyParsingException(Exception exception) {
111110
log.error("{} {}", INVALID_REQUEST_BODY_MESSAGE, exception.getMessage());
112111
return objectMapper.createResultFromExecutionResult(
113112
new ExecutionResultImpl(new GenericGraphQLError(INVALID_REQUEST_BODY_MESSAGE)));

graphql-spring-boot-autoconfigure/src/test/java/graphql/kickstart/autoconfigure/web/servlet/test/extendedscalars/ExtendedScalarAutoConfigurationTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
classes = ExtendedScalarAutoConfigurationTest.ExtendedScalarsTestApplication.class)
1919
@TestPropertySource(properties = "graphql.extended-scalars=BigDecimal")
2020
@DisplayName("Testing extended scalars auto configuration")
21-
public class ExtendedScalarAutoConfigurationTest {
21+
class ExtendedScalarAutoConfigurationTest {
2222

2323
@Autowired private ApplicationContext applicationContext;
2424

graphql-spring-boot-autoconfigure/src/test/java/graphql/kickstart/autoconfigure/web/servlet/test/extendedscalars/ExtendedScalarsTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
import org.springframework.core.env.StandardEnvironment;
1919

2020
@DisplayName("Testing extended scalars configuration")
21-
public class ExtendedScalarsTest {
21+
class ExtendedScalarsTest {
2222

2323
@Test
2424
@DisplayName(

0 commit comments

Comments
 (0)